Cache fragment metadata for workspaces on the cloud #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@mlathara, wondering if you can re-review this? Thanks. |
mlathara
approved these changes
Dec 15, 2024
Member
mlathara
left a comment
mlathara
left a comment
There was a problem hiding this comment.
minor comment, feel free to merge without addressing it
|
|
||
|
|
||
| # get tiledb offsets for interval | ||
| def parse_interval(interval: str): |
Member
There was a problem hiding this comment.
I dunno if this is better or worse than regex -- but maybe we could consider using string split (plus check for existence of the delimiter). Might be simpler
Member
Author
There was a problem hiding this comment.
This is done just while parsing intervals for the cli. I don't expect much time spent on this function. Guess using split is simpler.
nalinigans
added a commit
that referenced
this pull request
Dec 16, 2024
* Cache fragment metadata for workspaces on the cloud * Add examples workspace for testing * Run test.sh for the non-cloud case * Cache metadata per array rather than the entire workspace based on intervals being queried
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache fragment metadata for workspaces on the cloud and add GitHub actions to test scripts in examples on azurite.