Add back filter support and add support for --list-partitions with intervals, --list-fields and --attributes from genomicsdb_query#71
Merged
nalinigans merged 8 commits intodevelopfrom Jan 6, 2025
Conversation
nalinigans
changed the title
mlathara
approved these changes
Jan 6, 2025
| if isinstance(contig, str): # Old style vidmap json | ||
| contig_name = contig | ||
| contigs_map[contig] = { | ||
| contig_elem = { |
Member
There was a problem hiding this comment.
We may not need this, but doesn't contig_elem also have a name in the vcf2genomicsdb_init case?
Member
Author
There was a problem hiding this comment.
Yes, it does in the vcf2genomicsdb_init case, but are really ignoring as the contigs map is a dict for faster lookup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes and new support: