Skip to content

Conversation

@bpeng
Copy link
Contributor

@bpeng bpeng commented Jan 6, 2026

NOTE: This update fails the tests, probably caused by bugs in s3_concurrent, with test errors:

  1. commit: 69446141224fbb47afb6540ca05d475732757853 feat: GetAllConcurrentlyWithContext function
    test blocks at TestS3GetAllConcurrentlyWithContext_Cancel/cancel-during-processing:

  2. commit: 2630db5a809e4e450148d23b8c5897afcde29fe3 feat: update GetAllConcurrentlyWithContext to fix test failure:
    worker pools not recovered:

=== RUN   TestS3GetAllConcurrentlyWithContext_Cancel/cancel-during-processing
    s3_concurrent_test.go:290: 
        	Error Trace:	s3_concurrent_test.go:290
        	Error:      	Condition never satisfied
        	Test:       	TestS3GetAllConcurrentlyWithContext_Cancel/cancel-during-processing
        	Messages:   	workers pool not recovered, expected 100 actual 94

Further investigation is needed to fix the bugs.

Proposed Changes

Changes proposed in this pull request:

  • Add context in S3 GetAllConcurrently function to allow handle context cancel

Production Changes

The following production changes are required to deploy these changes:

  • None

Review

Check the box that applies to this code review. If necessary please seek help with adding a checklist guide for the reviewer.
When assigning the code review please consider the expertise needed to review the changes.

  • This is a content (documentation, web page etc) only change.
  • This is a minor change (meta data, bug fix, improve test coverage etc).
  • This is a larger change (new feature, significant refactoring etc). Please use the code review guidelines to add a checklist below to guide the code reviewer.

Code Review Guide

Copy link
Contributor

@wilsonjord wilsonjord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok. Do you think these new Context functions should be in the tests?

@bpeng bpeng force-pushed the s3-update branch 15 times, most recently from a181f6c to 2630db5 Compare January 10, 2026 17:59
@bpeng bpeng changed the title feat: add context in s3 Get functions feat: context aware concurrent S3 Jan 11, 2026
@bpeng bpeng marked this pull request as draft January 11, 2026 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants