feat: context aware concurrent S3 #201
Draft
+292
−30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This update fails the tests, probably caused by bugs in
s3_concurrent, with test errors:commit:
69446141224fbb47afb6540ca05d475732757853 feat: GetAllConcurrentlyWithContext functiontest blocks at TestS3GetAllConcurrentlyWithContext_Cancel/cancel-during-processing:
commit:
2630db5a809e4e450148d23b8c5897afcde29fe3feat: update GetAllConcurrentlyWithContext to fix test failure:worker pools not recovered:
Further investigation is needed to fix the bugs.
Proposed Changes
Changes proposed in this pull request:
GetAllConcurrentlyfunction to allow handle context cancelProduction Changes
The following production changes are required to deploy these changes:
Review
Check the box that applies to this code review. If necessary please seek help with adding a checklist guide for the reviewer.
When assigning the code review please consider the expertise needed to review the changes.
Code Review Guide