Skip to content

191 pushes to master should trigger merges and pushes to other protected branches#244

Open
Martin20494 wants to merge 13 commits intootakaro_digital_twinfrom
191-pushes-to-master-should-trigger-merges-and-pushes-to-other-protected-branches
Open

191 pushes to master should trigger merges and pushes to other protected branches#244
Martin20494 wants to merge 13 commits intootakaro_digital_twinfrom
191-pushes-to-master-should-trigger-merges-and-pushes-to-other-protected-branches

Conversation

@Martin20494
Copy link
Contributor

DESCRIPTION OF PR: Create automerge function to merge master and branch

Closes: #191

Developer Checklist

  • Make code change
  • Update tests
    • Update / create new tests
    • Ensure these tests have the expected behaviour
    • Test locally and ensure tests are passing
  • Update documentation
    • Readme
    • Docstrings
    • Comments
    • Wiki

Reviewer Checklist

  • Check new code for code smells
  • Check new tests
    • Ensure adequate coverage
    • Check for code smells within tests
  • Check if documentation needs updating
    • Readme
    • Docstrings
    • Comments
    • Wiki

Copy link
Member

@LukeParky LukeParky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work this looks like it works brilliantly. My comments about Build Documentation.yml may be difficult to fit in so focus on the other comments first, and come back to me about for some discussion around if you think the build_documentation comments are worthwhile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pushes to master should trigger merges and pushes to other protected branches

2 participants