Skip to content

Allow current year to be selected for sea-level rise projections#371

Merged
LukeParky merged 2 commits intomasterfrom
369-current-year-is-not-suitable-for-some-model-forecasting
Jan 22, 2026
Merged

Allow current year to be selected for sea-level rise projections#371
LukeParky merged 2 commits intomasterfrom
369-current-year-is-not-suitable-for-some-model-forecasting

Conversation

@LukeParky
Copy link
Member

NIWA's tide dataset allows the current year to be selected. Instead of setting the valid input parameters to next year manually, we should just allow the current year to be selected for Projected Year.

Developer Checklist

  • Make code change
  • Update tests
    • Update / create new tests
    • Ensure these tests have the expected behaviour
    • Test locally and ensure tests are passing
  • Update documentation
    • Readme
    • Docstrings
    • Comments
    • Wiki

Reviewer Checklist

  • Check new code for code smells
  • Check new tests
    • Ensure adequate coverage
    • Check for code smells within tests
  • Check if documentation needs updating
    • Readme
    • Docstrings
    • Comments
    • Wiki

@LukeParky LukeParky self-assigned this Jan 22, 2026
@LukeParky LukeParky linked an issue Jan 22, 2026 that may be closed by this pull request
@LukeParky LukeParky force-pushed the 369-current-year-is-not-suitable-for-some-model-forecasting branch from bc2a28c to 59ee768 Compare January 22, 2026 21:58
@sonarqubecloud
Copy link

@GRI-Admin GRI-Admin marked this pull request as ready for review January 22, 2026 22:50
@LukeParky LukeParky merged commit 715dcfb into master Jan 22, 2026
10 checks passed
@LukeParky LukeParky deleted the 369-current-year-is-not-suitable-for-some-model-forecasting branch January 22, 2026 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Current year is not suitable for some model forecasting.

2 participants