Conversation
… to remove floodresilience module from upstream library entirely
|
LukeParky
left a comment
LukeParky
left a comment
There was a problem hiding this comment.
Some easy comments, some investigation, and some that may require a separate issue
| <string>EPSG:2193</string> | ||
| </responseSRS> | ||
| <srs>EPSG:2193</srs> | ||
| </coverage> No newline at end of file |
There was a problem hiding this comment.
add issue to pull some of the EPSG:3857 optimisation changes from water-tracing-dashboard
|
|
||
|
|
||
| def add_style(style_name: str, style_xml: bytes) -> None: | ||
| """#todo""" |
| """Create a GeoServer style for flood rasters using the viridis color scale.""" | ||
| style_name = "viridis_raster" | ||
| with open('./src/eddie_floodresilience/flood_model/templates/viridis_raster.sld', 'rb') as payload: | ||
| add_style(style_name, payload) |
There was a problem hiding this comment.
This may be more appropriate to be in the FReDT repo, since it concerns water depth
There was a problem hiding this comment.
Why did this move from raster_layers to geoserver_common? Investigate this.
| eddie_plugins = discover_plugins() | ||
| for name, module in eddie_plugins.items(): | ||
| importlib.import_module(f"{name}.blueprint") | ||
| app.register_blueprint(module.blueprint.blueprint) | ||
|
|
There was a problem hiding this comment.
Confirm how well this works and its ease of setting up and potential conflicts with other packages that already exist on PyPi or conda-forge or elsewhere
| for _finder, name, _is_pkg in pkgutil.iter_modules() if name.startswith('eddie_') | ||
| } | ||
| log.info(f"Plugins discovered: {plugins}") | ||
| return plugins No newline at end of file |
| setup_logging() | ||
| log = logging.getLogger(__name__) | ||
|
|
||
| def discover_plugins() -> dict[str, ModuleType]: |
There was a problem hiding this comment.
Add docstring. Does this indicate a broken linting rule? Investigate
1 participant
DESCRIPTION OF PR:
This PR is closely coupled with GeospatialResearch/eddie_floodresilience#2
It is a large piece of work, fully separating the core functionality of EDDIE (data aggregation and processing) from the flood-resilience module (FReDT). This culminates in them becoming two separate modules.
The majority of the code has been extracted, but documentation needs to be finalised and code review needs to take place to make sure some of the code around configuration and GeoServer is in the correct repos.
Developer Checklist
Reviewer Checklist