Improve CallService lifecycle, notification handling, and ringing-to-active transition #1588

rahul-lohra · 2025-12-23T07:30:06Z

Goal

Fix FG Service Notification dismiss from Notification Tray
Fix Ringing State update process
Reuse same FG Service when transitioning from Ringing to Active Call instead of killing & respawn FG Service
Split Call Service into smaller classes

Implementation

Core Changes

Core classes

ClientState
CallState

Class	Change description
ClientState	Instead of stopping restarting service we are now transitioning incoming/outgoing call to active on the same service
CallState	- Prevent race-condition in event consumption & processing in Service Class by firing new local events when their original events are consumed -Since we will use same service to transition from ringing to active so we need to store a reference of original notification Id - Process `LocalCallMissedEvent` here so that it will work for calls which are not active

Service classes refactoring

Class	Change description
ServiceIntentBuilder	Creates and configures the various Intent objects used to communicate with the CallService.
ServiceLauncher	Provides a clean and centralized API to start, stop, and interact with the CallService.
CallServiceLifecycleManager	Manages the core business logic of starting, ending, and handling the lifecycle of a call.
CallServiceNotificationManager	Responsible for creating, displaying, and updating all notifications shown by the service.
ServiceState	The single source of truth that holds the current state of the service, such as active and ringing call IDs.
CallServiceEventObserver	Listens to VideoEvent changes from the Call and updates the ServiceState accordingly.
CallServiceNotificationUpdateObserver	Observes state changes and triggers updates to the foreground notification.
CallServiceRingingStateObserver	Manages the ringing state and handles transitions between incoming, active, and idle calls.

Util Classes

Class	Change description
Debouncer	To debounce the stopping of FG Service to ensure enough time has passed for the system to process the notification removal.
Throttler	Throttling the service by [CallService.SERVICE_DESTROY_THROTTLE_TIME_MS] such that the stop service is invoked once (at least less frequently)

Testing

Fix FG Service Notification dismiss from Notification Tray

Open the notification drawer in callee phone
Make a call and end the call within 1-2 second.
The notification should properly update on the callee's phone

Service lifecycle

When a call is ended, service should get destroyed (check from the logs)

Summary by CodeRabbit

New Features
- Missed-call notifications now include caller/creator info and use stable notification IDs.
- Notifications and foreground service starts are permission-aware and choose appropriate service types.
- Debouncing/throttling reduces rapid stop/start service actions for smoother behavior.
Bug Fixes
- More consistent ringing → accepted transitions across devices.
- Improved notification lifecycle: better updates, cancellations, and timing when multiple calls occur.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Adds more detailed logging to the `CallEventObserver` to provide better insight into the handling of incoming call events.

When a `CallRejectedEvent` is received, the `createdBy` field on the call state is now updated with the user who created the call.

Introduces `LocalCallAcceptedEvent` and `LocalCallRejectedEvent` to represent call state changes originating from the local device. These new local events are now used in `CallEventObserver` instead of the generic `CallAcceptedEvent` and `CallRejectedEvent`, providing a clearer distinction for handling call lifecycle states like accepting a call. Additionally, `CallState` now fires these local events, improving the accuracy of event-driven logic.

# Conflicts: # stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/Call.kt # stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/notifications/internal/service/CallService.kt

Adds a reason when leaving a call from the `CallLifecycleManager`. This provides more context for why the call was ended, distinguishing between different scenarios such as the task being removed for an ongoing or incoming call.

github-actions · 2025-12-23T08:00:22Z

PR checklist ✅

All required conditions are satisfied:

Title length is OK (or ignored by label).
At least one pr: label exists.
Sections ### Goal, ### Implementation, and ### Testing are filled.

🎉 Great job! This PR is ready for review.

github-actions · 2025-12-23T08:07:13Z

SDK Size Comparison 📏

SDK	Before	After	Difference	Status
stream-video-android-core	11.94 MB	11.96 MB	0.02 MB	🟢
stream-video-android-ui-xml	5.68 MB	5.68 MB	0.00 MB	🟢
stream-video-android-ui-compose	6.27 MB	6.27 MB	0.00 MB	🟢

Renames several components within the `CallService` infrastructure to improve clarity by prefixing them with "CallService". This includes managers and observers. The events `LocalCallAcceptedEvent` and `LocalCallRejectedEvent` are renamed to `LocalCallAcceptedPostEvent` and `LocalCallRejectedPostEvent` respectively to better reflect their purpose. Additionally, this change introduces a comprehensive suite of unit tests for the `CallService` and its related components, covering: - Lifecycle and notification management - Event, ringing state, and notification update observers - Foreground service permission handling - Debouncer and Throttler utilities

Renames `LocalCallAcceptedEvent` and `LocalCallRejectedEvent` to `LocalCallAcceptedPostEvent` and `LocalCallRejectedPostEvent` respectively, to better reflect that they are events sent *after* the action has occurred.

Adds `notificationId` as a parameter to the `updateNotification` function. This allows for updating the notification with a specific ID. The previous `updateNotification` function without the ID has been deprecated.

Adds an overloaded version of the `updateNotification` method that doesn't require a notification ID, simplifying its usage.

The `transitionToAcceptCall` function in `ClientState` is now marked as `internal`, restricting its usage to within the same module. This change also updates the public API definition.

Removes an unnecessary `stopService` call that was being made immediately after `startService` in `ServiceLauncher`.

Adds a TODO comment to `DefaultNotificationDispatcher.kt` to ensure a new fix is verified before merging.

Adds the `RobolectricTestRunner` to `ServiceStateTest` to address test failures that occurred when running all tests together. The `unregisterToggleCameraBroadcastReceiver` test has been moved to the end of the file as it was failing for unknown reasons, and a `println` has been added for debugging.

When a call is initiated, it now transitions through the `RingingState.Outgoing` state. This change ensures that a foreground service with an outgoing call notification is started, providing immediate feedback to the user that a call is being placed. A delay is introduced before starting the foreground service for outgoing calls to allow the system to properly transition the call state.

stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/events/LocalEvent.kt

...rc/main/kotlin/io/getstream/video/android/core/notifications/internal/service/CallService.kt

...ream/video/android/core/notifications/internal/service/observers/CallServiceEventObserver.kt

...kotlin/io/getstream/video/android/core/notifications/internal/service/models/ServiceState.kt

...oid-core/src/main/kotlin/io/getstream/video/android/core/notifications/internal/Debouncer.kt

...video/android/core/notifications/internal/service/managers/CallServiceNotificationManager.kt

...am/video/android/core/notifications/internal/service/managers/CallServiceLifecycleManager.kt

...deo/android/core/notifications/internal/service/observers/CallServiceRingingStateObserver.kt

...rc/main/kotlin/io/getstream/video/android/core/notifications/internal/service/CallService.kt

aleksandar-apostolov · 2026-01-15T17:05:50Z

Its a good refactor which extracts some concerns from the CallService. I left some comments that we need to look into before merging.

aleksandar-apostolov · 2026-01-19T08:39:19Z

Shouldn't this go towards develop instead?

rahul-lohra · 2026-01-19T10:07:41Z

Shouldn't this go towards develop instead?

Yes I will correct it

sonarqubecloud · 2026-01-22T10:32:02Z

Quality Gate failed

Failed conditions
1 Security Hotspot
55.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

rahul-lohra added 12 commits December 17, 2025 15:03

Refactor call service into smaller classes

f3990a7

chore: add logging to notification and lifecycle managers

7b0942c

feat: Add logging to CallEventObserver

dc7f077

Adds more detailed logging to the `CallEventObserver` to provide better insight into the handling of incoming call events.

feat: Update createdBy on call rejected event

55f48bb

When a `CallRejectedEvent` is received, the `createdBy` field on the call state is now updated with the user who created the call.

chore: add createdByUserId in LocalCallMissedEvent

6f190b7

chore: fix missed imports

67ffeae

chore: fix service cancellation from LocalCallMissedEvent

d164b57

chore: refactor

9ae4455

chore: fix notification id for missed-call

2992616

chore: add logic for time-sensitive services

5cb2299

chore: temp

594cc89

rahul-lohra self-assigned this Dec 23, 2025

rahul-lohra added 2 commits December 23, 2025 13:18

Merge branch 'develop' into bugfix/rahullohra/refactor-call-service

0998fac

# Conflicts: # stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/Call.kt # stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/notifications/internal/service/CallService.kt

feat: Add reason when leaving call from service

58afb52

Adds a reason when leaving a call from the `CallLifecycleManager`. This provides more context for why the call was ended, distinguishing between different scenarios such as the task being removed for an ongoing or incoming call.

aleksandar-apostolov and others added 13 commits December 24, 2025 10:32

Merge branch 'develop' into bugfix/rahullohra/refactor-call-service

b5b95e1

refactor: Rename local call events

3527dd2

Renames `LocalCallAcceptedEvent` and `LocalCallRejectedEvent` to `LocalCallAcceptedPostEvent` and `LocalCallRejectedPostEvent` respectively, to better reflect that they are events sent *after* the action has occurred.

feat: Add notificationId to updateNotification

5a14940

Adds `notificationId` as a parameter to the `updateNotification` function. This allows for updating the notification with a specific ID. The previous `updateNotification` function without the ID has been deprecated.

feat: Add updateNotification without notification ID

776b4b5

Adds an overloaded version of the `updateNotification` method that doesn't require a notification ID, simplifying its usage.

feat: Make transitionToAcceptCall internal

697b82a

The `transitionToAcceptCall` function in `ClientState` is now marked as `internal`, restricting its usage to within the same module. This change also updates the public API definition.

fix: Remove stopService call from ServiceLauncher

8346b9e

Removes an unnecessary `stopService` call that was being made immediately after `startService` in `ServiceLauncher`.

chore: Add a TODO comment

94138cc

Adds a TODO comment to `DefaultNotificationDispatcher.kt` to ensure a new fix is verified before merging.

chore: Add a TODO comment

c60b687

Adds a TODO comment to `DefaultNotificationDispatcher.kt` to ensure a new fix is verified before merging.

Merge branch 'develop' into bugfix/rahullohra/refactor-call-service

cd1cf38

chore: Improve documentation and make local events internal

ab9b2be