Skip to content

Proposal "Test Reports Folder structure"#2

Open
GetmanetsIrina wants to merge 4 commits intomasterfrom
feature/ATFtestReportsFolderStruct
Open

Proposal "Test Reports Folder structure"#2
GetmanetsIrina wants to merge 4 commits intomasterfrom
feature/ATFtestReportsFolderStruct

Conversation

@GetmanetsIrina
Copy link
Owner

@GetmanetsIrina GetmanetsIrina commented Nov 7, 2017

This PR contains proposal for SDL evolution regarding changing of ATF test report structure

## Introduction

For now ATF reports folder have inconvenient nested struct. ATF creates struct of folders from relative path to script.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GetmanetsIrina

  • folder has

  • It would be good to see the current folder structure and what exactly is inconvenient in order to understand the difference with proposed solution

  • maybe it worth to name the proposal like "Change ATF test report folder structure" so it will reflect the sense more clear

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dev-gh
Copy link

dev-gh commented Nov 7, 2017

@GetmanetsIrina
Please add some meaningful description for PR e.g. "This PR contains proposal for SDL evolution regarding changing of ATF test report structure"

Main folder 'TestingReports'
-> Subfolder '<ScriptName>_<timestamp>'
->Subfolder 'ATF'
->Subfolder 'SDL'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GetmanetsIrina
In the final view this text loses its formatting so very hard to read and understand what is the proposed structure. Please wrap this part as code or insert picture or whatever to make that clear for the people to understand.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GetmanetsIrina
Copy link
Owner Author

@dev-gh please find changes in commit c7a41f3

## Proposed solution

The solution is to create new struct:
<pre><code>Main folder 'TestingReports'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GetmanetsIrina
Sugestion is to remove 'Main folder', 'Subfolder' and single quotes in order to conform example in 'Introduction' section


## Impact on existing code

Impact on ATF reporting functionality.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GetmanetsIrina Please note that CI jobs will require an update


## Introduction

For now ATF reports folder has inconvenient nested struct. ATF creates struct of folders from relative path to script, e.g. runned script fom test_scripts/API/Navidation/Subscriptions/.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GetmanetsIrina What is struct? Please use full words instead of abbreviations.

@GetmanetsIrina
Copy link
Owner Author

@dboltovskyi , @AByzhynar please fing changes in commit 2d2ef88


## Introduction

For now ATF reports folder has inconvenient nested struct. ATF creates structure of folders from relative path to script, e.g. runned script fom test_scripts/API/Navidation/Subscriptions/.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GetmanetsIrina For now ATF reports folder has inconvenient nested struct


## Proposed solution

The solution is to create new struct:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GetmanetsIrina I propose use structure instead of struct here

@GetmanetsIrina GetmanetsIrina force-pushed the feature/ATFtestReportsFolderStruct branch from b860be1 to d7fdb1b Compare November 8, 2017 06:35
@GetmanetsIrina
Copy link
Owner Author

@aderiabin, @AByzhynar, @dev-gh, please find changes in commit d7fdb1b

Updated Motivation section according to review comment.
GetmanetsIrina pushed a commit that referenced this pull request Apr 12, 2018
* SendLocation for Mobile Nav

This proposal is about extending the capability for apps to receive and service SendLocation requests from other apps which is currently limited to the Head Unit's embedded navigation system.

* Updating links to assets

* Updated links to assets

* Create a

* Asset #1

* asset #2

* Delete a

* Delete SendLocationForMobileNav_RAI.jpg

* Add files via upload

* Delete SendLocationForMobileNav_RequestResponse.jpg

* Add files via upload

* Addressed comments
GetmanetsIrina added a commit that referenced this pull request Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants