Skip to content

Use external prop-types package #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ItamarAbeliovich wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use external prop-types package #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
095ef0f
Hopefully now uses the new prop-types npm package
ItamarAbeliovich Nov 26, 2017
acd6c05
Fixed package.json
ItamarAbeliovich Nov 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ var taskConfig = {
dependencies: [
'classnames',
'react',
'react-dom'
'react-dom',
'prop-types'
],
lib: 'lib'
},
Expand Down
6 changes: 5 additions & 1 deletion lib/ReactInputValidation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,12 @@ function _inherits(subClass, superClass) { if (typeof superClass !== 'function'

var _react = require('react');

var PropTypes = require('prop-types');

var _react2 = _interopRequireDefault(_react);

_react2['default'].PropTypes = PropTypes;

var _libValidationRules = require('./lib/validation-rules');

var _libValidationRules2 = _interopRequireDefault(_libValidationRules);
Expand Down Expand Up @@ -223,4 +227,4 @@ ReactInputValidation.propTypes = {
addonPos: _react2['default'].PropTypes.string, // position of addon, default is 'right'
ref: _react2['default'].PropTypes.string // always use this for validating (must be unique)
};
module.exports = exports['default'];
module.exports = exports['default'];
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@
"url": "https://github.com/ggayane/react-input-validation/issues"
},
"dependencies": {
"classnames": "^2.1.2"
"classnames": "^2.1.2",
"prop-types": "^15.6.0"
},
"devDependencies": {
"babel-eslint": "^4.1.3",
Expand Down