Skip to content

fix: signup option visible in production (resolves #165) #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Harshitraaaj wants to merge 1 commit into from
Closed

fix: signup option visible in production (resolves #165) #175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pages/Signup/Signup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ const navigate = useNavigate();
<p className="text-purple-200 text-lg">Join your GitHub journey</p>
</div>

{/* Sign Up Form */}
{/* Sign Up Form */}
Copy link
Contributor

@coderabbitai coderabbitai bot Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

No functional change – issue #165 remains unaddressed

The diff only adds a trailing space inside a comment. There is no runtime-visible change that would hide the “Sign Up” option in production, so the stated objective of resolving #165 is still unmet.

Please verify that the necessary logic (e.g., env-based conditional rendering, route guards, or feature-flag checks) is implemented elsewhere or include it in this PR.

🏁 Script executed:

#!/usr/bin/env bash
set -e

echo "🔍 Searching for references to issue #165"
rg -n '#165' .

echo "🔍 Searching for 'Sign Up' literal occurrences"
rg -n 'Sign Up' .

echo "🔍 Searching for Signup component usage in JSX"
rg -n '<Signup' .

echo "🔍 Searching for environment-based or feature-flag checks"
rg -n -e 'process.env' -e 'featureFlag' -e 'FeatureFlag' .

Length of output: 118

🏁 Script executed:

#!/usr/bin/env bash

echo "🔍 Displaying src/pages/Signup/Signup.tsx around line 78"
sed -n '60,100p' src/pages/Signup/Signup.tsx || { echo "File not found"; exit 1; }

echo "🔍 Searching for env/feature-flag checks in Signup.tsx"
grep -n -E 'process\.env|featureFlag|FeatureFlag|enableSignup|signupEnabled|isSignupEnabled|useFeature|Conditional' src/pages/Signup/Signup.tsx || echo "No guards found in Signup.tsx"

echo "🔍 Searching globally for signup guard or feature-flag patterns"
rg -n -e 'signupEnabled' -e 'enableSignup' -e 'isSignupEnabled' -e 'routeGuard' -e 'ProtectedRoute' -e 'useFeature' . || echo "No global flags/guards found"

Length of output: 3214

Signup rendering still unconditional – feature-flag or guard logic missing

Our review of src/pages/Signup/Signup.tsx (lines 60–100) shows that the PR only adds a trailing space in a comment. There are no environment-based checks, feature-flag hooks, or route guards around the “Sign Up” form, so issue #165 remains unaddressed. To resolve #165, please implement one of the following:

• Wrap the signup form in a conditional, e.g.:

if (!process.env.REACT_APP_ENABLE_SIGNUP) return null;

• Use your existing feature-flag hook or HOC, e.g.:

const isEnabled = useFeature("signup");
if (!isEnabled) return null;

• Protect the signup route via a <ProtectedRoute> or route-guard component.

File needing update:

  • src/pages/Signup/Signup.tsx (around line 78)
🤖 Prompt for AI Agents 
In src/pages/Signup/Signup.tsx around line 78, the Sign Up form is rendered
unconditionally without any feature-flag or guard logic, which does not address
issue #165. To fix this, wrap the Sign Up form rendering in a conditional check
using either an environment variable like process.env.REACT_APP_ENABLE_SIGNUP or
a feature-flag hook such as useFeature("signup"). If the feature is disabled,
return null to prevent rendering the form. Alternatively, protect the route with
a <ProtectedRoute> or similar guard component to control access based on the
feature flag.

<div className="bg-white/10 backdrop-blur-lg rounded-3xl p-8 border border-white/20 shadow-2xl">
<h2 className="text-2xl font-semibold text-white text-center mb-8">Create Account</h2>

Expand Down