Skip to content

discriminate between en-dash, em-dash#6

Open
nschloe wants to merge 1 commit intoGitbookIO:masterfrom
nschloe:patch-1
Open

discriminate between en-dash, em-dash#6
nschloe wants to merge 1 commit intoGitbookIO:masterfrom
nschloe:patch-1

Conversation

@nschloe
Copy link

@nschloe nschloe commented Nov 4, 2014

Typically, en-dashes are created by double dashes --, em-dashes by triple dashes --- (e.g., compose key syntax or LaTeX). This pull request implements this behavior.

Typically, en-dashes are created by double dashes `--`, em-dashes by triple dashes `---` (e.g., [compose key syntax](http://en.wikipedia.org/wiki/Wikipedia:How_to_make_dashes) or [LaTeX](http://tex.stackexchange.com/a/3821/13262)). This pull request implements this behavior.
@AaronO
Copy link
Contributor

AaronO commented Nov 4, 2014

@nschloe Thanks for the PR ! It looks great overall. And it makes sense to distinguish both.

However could you fix the tests ?

  1. Update test/tests/text.smartypants.html to use en dashes rather than em dashes.
  2. Add some em dashes both in the markdown and html

(You can run tests with npm test).

@AaronO
Copy link
Contributor

AaronO commented Jan 29, 2015

@nschloe Any update on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants