Open
Conversation
Contributor
|
@umairishaq thank you for the pull request. Now when looking at the changes made. a lot of changes don't seem to be related to the proposed fix, but are rather related to the addition or removal of spaces, hence reformatting of the file. Could you reapply your changes on the original formatted version so that it will be a lot clearer what the actual changes are? Thanks a lot and sorry for the additional work this means |
Contributor
|
+1 with @CGijbels here - https://github.com/Glimpse/Glimpse.Client/pull/55/files. Once its fixed we can do a better review. |
Author
|
Thank you very much for the comments guys. I'll resubmit shortly. |
This reverts commit 0fc16af.
Author
|
Should be good to go now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The addition provides the solution for glimpse # 397.