Conversation
Contributor
📝 WalkthroughWalkthroughComprehensive version bump across the codebase from nightly placeholders (0.0.0-nightly) to specific release versions (1.16.0 and 5.16.0). Updates affect Helm chart metadata, values, documentation, Dockerfiles, shell scripts, and supporting configuration files. Additionally updates several JANS_SOURCE_VERSION and FLEX_SOURCE_VERSION environment variables in Dockerfiles. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mo-auto
added
area-CI
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
automation/rancher-partner-charts/questions.yaml (1)
703-939: None of the image tags in the defaults are published in their registries.All verified image tags returned 404 (not found) or 401 errors:
- ghcr.io/janssenproject/jans/auth-server:1.16.0-1 → HTTP 401
- gluufederation/admin-ui:5.16.0-1 → HTTP 404
- janssenproject/certmanager:1.16.0-1 → HTTP 404
- gluufederation/casa:1.16.0-1 → HTTP 404
- janssenproject/configurator:1.16.0-1 → HTTP 404
- janssenproject/config-api:1.16.0-1 → HTTP 404
- janssenproject/fido2:1.16.0-1 → HTTP 404
- janssenproject/persistence-loader:5.16.0-1 → HTTP 404
- janssenproject/scim:1.16.0-1 → HTTP 404
Helm installations using these defaults will fail at image pull time. Update the tag defaults to versions that have been published to their respective registries.
charts/gluu/charts/auth-server-key-rotation/README.md (1)
44-45: Pre-existing duplicatenodeSelectorentry in Values table.Lines 44 and 45 both define
nodeSelector— one without a description and one with. This appears to be a pre-existing issue in the generated documentation, not introduced by this PR.Consider cleaning this up in a follow-up if the README is auto-generated (check the helm-docs configuration) or manually if not.
🤖 Fix all issues with AI agents
In `@charts/gluu-all-in-one/values.yaml`:
- Line 325: The values.yaml currently references image tag "tag: 1.16.0-1" for
images that are not published (e.g., janssenproject/jans/cloudtools:1.16.0-1 and
gluufederation/flex-all-in-one:5.16.0-1); build and publish the missing image
tags to their registries (GHCR for janssenproject/jans/cloudtools and Docker Hub
for gluufederation/flex-all-in-one), or update the values.yaml entries to point
to existing published tags, and repeat the fix for the other occurrences noted
(the other "tag: 1.16.0-1" references around the file: occurrences at the
locations mentioned in the review) so that all image references resolve at
deploy time.
In `@charts/gluu/charts/cn-istio-ingress/README.md`:
- Line 1: Top-level heading in README.md currently uses H1 ("#
cn-istio-ingress"); change it to an H2 by replacing the single '#' with '##' so
the top-level heading reads "## cn-istio-ingress" to match repository Markdown
conventions and other docs; update the heading in the README.md file where the
"cn-istio-ingress" heading is defined.
In `@charts/gluu/values.yaml`:
- Line 90: The values.yaml currently pins images to non-existent tags (e.g.,
tag: 5.16.0-1) which will make the release fail; either publish the missing GHCR
images or update values.yaml to use published image tags for each referenced
image (gluufederation/flex/admin-ui, gluufederation/flex/persistence-loader and
the janssenproject/* images: auth-server, cloudtools, configurator, config-api,
fido2, casa, scim, saml). Locate the image tag entries in values.yaml (the
central tag: 5.16.0-1 and any per-image tag overrides) and replace them with
valid, existing GHCR tags (or set them to an explicit published version) for
each of the ten images, then verify by pulling those image:tag combinations
before merging.
In `@docs/reference/kubernetes/helm-chart.md`:
- Line 347: The bare URL in the table cell for gatewayApi.gatewayClassName
violates markdownlint MD034; update that table row (the cell containing "See
https://gateway-api.sigs.k8s.io/implementations/#conformant") to wrap the URL so
it's not a bare URL — e.g., enclose it in angle brackets or convert it to a
markdown link — ensuring the rest of the row text remains unchanged.
| repository: ghcr.io/janssenproject/jans/cloudtools | ||
| # -- Image tag to use for deploying. | ||
| tag: 0.0.0-nightly | ||
| tag: 1.16.0-1 |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
python - <<'PY'
import json, urllib.request, sys
images = [
("janssenproject/jans/cloudtools", "1.16.0-1"),
("gluufederation/flex/flex-all-in-one", "5.16.0-1"),
]
def fetch_json(url, headers=None):
req = urllib.request.Request(url, headers=headers or {})
with urllib.request.urlopen(req) as resp:
return json.load(resp)
exit_code = 0
for repo, tag in images:
token = fetch_json(f"https://ghcr.io/token?service=ghcr.io&scope=repository:{repo}:pull")["token"]
tags = fetch_json(
f"https://ghcr.io/v2/{repo}/tags/list",
headers={"Authorization": f"Bearer {token}"}
).get("tags") or []
ok = tag in tags
print(f"{repo}:{tag} -> {'OK' if ok else 'MISSING'}")
if not ok:
exit_code = 1
sys.exit(exit_code)
PYRepository: GluuFederation/flex
Length of output: 182
🌐 Web query:
janssenproject/jans/cloudtools 1.16.0-1 GHCR container image tag
💡 Result:
The GHCR image tag is:
ghcr.io/janssenproject/jans/cloudtools:1.16.0-1. [1][2]
Sources: Janssen docs showing the same GHCR naming pattern for cloudtools/configurator images. [1] https://docs.jans.io/v1.9.0/janssen-server/kubernetes-ops/cert-management/ [2] https://docs.jans.io/v1.1.4/admin/reference/kubernetes/docker-jans-configurator/
🌐 Web query:
gluufederation/flex/flex-all-in-one 5.16.0-1 GHCR container image tag
💡 Result:
Do you want me to look up whether the GHCR image tag ghcr.io/gluufederation/flex/flex-all-in-one:5.16.0-1 exists and return the exact pull command / digest? I can search GHCR and GitHub Packages and report back.
🌐 Web query:
janssenproject jans 1.16.0-1 release GHCR published
💡 Result:
I couldn't find a GHCR (ghcr.io) container image or GitHub Packages entry for JanssenProject "jans" tagged 1.16.0-1. The project's GitHub repository and Docker Hub organization show releases/images but no ghcr.io package with that tag. [1][2]
Sources:
- JanssenProject GitHub repository (releases/tags view). [1]
- janssenproject images on Docker Hub. [2]
🌐 Web query:
gluufederation flex 5.16.0-1 release container image published
💡 Result:
Do you want me to check whether the GluuFederation Flex container image tagged 5.16.0-1 has been published (Docker Hub / GitHub Packages / GitHub Releases)? If so I will search Docker Hub, GitHub Releases/tags, and Gluu release notes and report back with links.
🌐 Web query:
GluuFederation Flex 5.16.0-1 Docker Hub GitHub Releases container image published
💡 Result:
Do you want me to check whether the Gluu Flex v5.16.0-1 container image has been published on Docker Hub and/or GitHub Releases (and, if so, provide links and publish dates)?
🌐 Web query:
gluufederation flex-all-in-one container image 5.16.0-1 exists published Docker
💡 Result:
I could not find a Docker image named gluufederation/flex-all-in-one:5.16.0-1 on Docker Hub. Gluu's docs and repositories reference a "monolith" / flex monolith image and other gluufederation images on Docker Hub, but there is no published tag matching 5.16.0-1 for a flex-all-in-one image. [1][2]
Sources:
- Gluu Flex Docker/monolith docs. [1]
- Gluufederation repositories and images on Docker Hub (organization overview / sample repos). [2]
The referenced container image tags are not currently published and must be created before release.
Verification confirms that the following images do not exist in their respective registries:
janssenproject/jans/cloudtools:1.16.0-1(not on GHCR)gluufederation/flex-all-in-one:5.16.0-1(not on Docker Hub)
These tags must be built and published to prevent pull failures when this release is deployed.
Also applies to: 736-736, 818-818, 881-881
🤖 Prompt for AI Agents
In `@charts/gluu-all-in-one/values.yaml` at line 325, The values.yaml currently
references image tag "tag: 1.16.0-1" for images that are not published (e.g.,
janssenproject/jans/cloudtools:1.16.0-1 and
gluufederation/flex-all-in-one:5.16.0-1); build and publish the missing image
tags to their registries (GHCR for janssenproject/jans/cloudtools and Docker Hub
for gluufederation/flex-all-in-one), or update the values.yaml entries to point
to existing published tags, and repeat the fix for the other occurrences noted
(the other "tag: 1.16.0-1" references around the file: occurrences at the
locations mentioned in the review) so that all image references resolve at
deploy time.
| @@ -1,6 +1,6 @@ | |||
| # cn-istio-ingress | |||
Contributor
There was a problem hiding this comment.
Use H2 heading instead of H1 for top-level heading.
The repository convention is to use H2 headings (##) as the top-level heading in Markdown documentation files, not H1 (#).
Based on learnings, Markdown docs in this repository should avoid H1 headings.
📝 Proposed fix
-# cn-istio-ingress
+## cn-istio-ingress📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| # cn-istio-ingress | |
| ## cn-istio-ingress |
🤖 Prompt for AI Agents
In `@charts/gluu/charts/cn-istio-ingress/README.md` at line 1, Top-level heading
in README.md currently uses H1 ("# cn-istio-ingress"); change it to an H2 by
replacing the single '#' with '##' so the top-level heading reads "##
cn-istio-ingress" to match repository Markdown conventions and other docs;
update the heading in the README.md file where the "cn-istio-ingress" heading is
defined.
| repository: ghcr.io/gluufederation/flex/admin-ui | ||
| # -- Image tag to use for deploying. | ||
| tag: 0.0.0-nightly | ||
| tag: 5.16.0-1 |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
python - <<'PY'
import json, urllib.request, sys
images = [
("gluufederation/flex/admin-ui", "5.16.0-1"),
("janssenproject/jans/auth-server", "1.16.0-1"),
("janssenproject/jans/cloudtools", "1.16.0-1"),
("janssenproject/jans/configurator", "1.16.0-1"),
("janssenproject/jans/config-api", "1.16.0-1"),
("janssenproject/jans/fido2", "1.16.0-1"),
("janssenproject/jans/casa", "1.16.0-1"),
("gluufederation/flex/persistence-loader", "5.16.0-1"),
("janssenproject/jans/scim", "1.16.0-1"),
("janssenproject/jans/saml", "1.16.0-1"),
]
def fetch_json(url, headers=None):
req = urllib.request.Request(url, headers=headers or {})
with urllib.request.urlopen(req) as resp:
return json.load(resp)
exit_code = 0
for repo, tag in images:
try:
token = fetch_json(f"https://ghcr.io/token?service=ghcr.io&scope=repository:{repo}:pull")["token"]
tags = fetch_json(
f"https://ghcr.io/v2/{repo}/tags/list",
headers={"Authorization": f"Bearer {token}"}
).get("tags") or []
ok = tag in tags
print(f"{repo}:{tag} -> {'OK' if ok else 'MISSING'}")
if not ok:
exit_code = 1
except Exception as e:
print(f"{repo}:{tag} -> ERROR: {e}")
exit_code = 1
sys.exit(exit_code)
PYRepository: GluuFederation/flex
Length of output: 1828
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Try using curl with insecure flag to check GHCR tags
images=(
"gluufederation/flex/admin-ui:5.16.0-1"
"janssenproject/jans/auth-server:1.16.0-1"
"janssenproject/jans/cloudtools:1.16.0-1"
"janssenproject/jans/configurator:1.16.0-1"
"janssenproject/jans/config-api:1.16.0-1"
"janssenproject/jans/fido2:1.16.0-1"
"janssenproject/jans/casa:1.16.0-1"
"gluufederation/flex/persistence-loader:5.16.0-1"
"janssenproject/jans/scim:1.16.0-1"
"janssenproject/jans/saml:1.16.0-1"
)
for img in "${images[@]}"; do
repo="${img%:*}"
tag="${img##*:}"
# Try to get token and check tags
token=$(curl -s -k "https://ghcr.io/token?service=ghcr.io&scope=repository:${repo}:pull" | jq -r '.token' 2>/dev/null || echo "")
if [ -z "$token" ]; then
echo "${img} -> UNABLE_TO_VERIFY (token fetch failed)"
continue
fi
tags=$(curl -s -k -H "Authorization: Bearer ${token}" "https://ghcr.io/v2/${repo}/tags/list" 2>/dev/null | jq -r '.tags[]?' 2>/dev/null || echo "")
if echo "$tags" | grep -q "^${tag}$"; then
echo "${img} -> OK"
else
echo "${img} -> MISSING"
fi
doneRepository: GluuFederation/flex
Length of output: 558
Critical: Container image tags do not exist in GHCR—release will fail.
All 10 referenced image tags are missing from their respective GHCR repositories:
gluufederation/flex/admin-ui:5.16.0-1janssenproject/jans/auth-server:1.16.0-1janssenproject/jans/cloudtools:1.16.0-1janssenproject/jans/configurator:1.16.0-1janssenproject/jans/config-api:1.16.0-1janssenproject/jans/fido2:1.16.0-1janssenproject/jans/casa:1.16.0-1gluufederation/flex/persistence-loader:5.16.0-1janssenproject/jans/scim:1.16.0-1janssenproject/jans/saml:1.16.0-1
Publish these container images before release or update the tags in values.yaml to use published versions.
🤖 Prompt for AI Agents
In `@charts/gluu/values.yaml` at line 90, The values.yaml currently pins images to
non-existent tags (e.g., tag: 5.16.0-1) which will make the release fail; either
publish the missing GHCR images or update values.yaml to use published image
tags for each referenced image (gluufederation/flex/admin-ui,
gluufederation/flex/persistence-loader and the janssenproject/* images:
auth-server, cloudtools, configurator, config-api, fido2, casa, scim, saml).
Locate the image tag entries in values.yaml (the central tag: 5.16.0-1 and any
per-image tag overrides) and replace them with valid, existing GHCR tags (or set
them to an explicit published version) for each of the ten images, then verify
by pulling those image:tag combinations before merging.
| | fido2.volumes | list | `[]` | Configure any additional volumes that need to be attached to the pod | | ||
| | global | object | `{"admin-ui":{"adminUiServiceName":"admin-ui","customAnnotations":{"deployment":{},"destinationRule":{},"horizontalPodAutoscaler":{},"pod":{},"podDisruptionBudget":{},"secret":{},"service":{},"virtualService":{}},"enabled":true,"ingress":{"adminUiAdditionalAnnotations":{},"adminUiEnabled":true,"adminUiLabels":{}}},"alb":{"ingress":false},"auth-server":{"appLoggers":{"auditStatsLogLevel":"INFO","auditStatsLogTarget":"FILE","authLogLevel":"INFO","authLogTarget":"STDOUT","enableStdoutLogPrefix":"true","httpLogLevel":"INFO","httpLogTarget":"FILE","persistenceDurationLogLevel":"INFO","persistenceDurationLogTarget":"FILE","persistenceLogLevel":"INFO","persistenceLogTarget":"FILE","scriptLogLevel":"INFO","scriptLogTarget":"FILE"},"authEncKeys":"RSA1_5 RSA-OAEP","authServerServiceName":"auth-server","authSigKeys":"RS256 RS384 RS512 ES256 ES384 ES512 PS256 PS384 PS512","cnCustomJavaOptions":"","customAnnotations":{"deployment":{},"destinationRule":{},"horizontalPodAutoscaler":{},"pod":{},"podDisruptionBudget":{},"secret":{},"service":{},"virtualService":{}},"enabled":true,"ingress":{"authServerAdditionalAnnotations":{},"authServerEnabled":true,"authServerLabels":{},"authServerProtectedRegister":false,"authServerProtectedRegisterAdditionalAnnotations":{},"authServerProtectedRegisterLabels":{},"authServerProtectedToken":false,"authServerProtectedTokenAdditionalAnnotations":{},"authServerProtectedTokenLabels":{},"authzenAdditionalAnnotations":{},"authzenConfigEnabled":true,"authzenConfigLabels":{},"deviceCodeAdditionalAnnotations":{},"deviceCodeEnabled":true,"deviceCodeLabels":{},"firebaseMessagingAdditionalAnnotations":{},"firebaseMessagingEnabled":true,"firebaseMessagingLabels":{},"lockAdditionalAnnotations":{},"lockConfigAdditionalAnnotations":{},"lockConfigEnabled":false,"lockConfigLabels":{},"lockEnabled":false,"lockLabels":{},"openidAdditionalAnnotations":{},"openidConfigEnabled":true,"openidConfigLabels":{},"u2fAdditionalAnnotations":{},"u2fConfigEnabled":true,"u2fConfigLabels":{},"uma2AdditionalAnnotations":{},"uma2ConfigEnabled":true,"uma2ConfigLabels":{},"webdiscoveryAdditionalAnnotations":{},"webdiscoveryEnabled":true,"webdiscoveryLabels":{},"webfingerAdditionalAnnotations":{},"webfingerEnabled":true,"webfingerLabels":{}},"lockEnabled":false},"auth-server-key-rotation":{"customAnnotations":{"cronjob":{},"secret":{},"service":{}},"enabled":true,"initKeysLife":48},"awsStorageType":"io1","azureStorageAccountType":"Standard_LRS","azureStorageKind":"Managed","casa":{"appLoggers":{"casaLogLevel":"INFO","casaLogTarget":"STDOUT","enableStdoutLogPrefix":"true","timerLogLevel":"INFO","timerLogTarget":"FILE"},"casaServiceName":"casa","cnCustomJavaOptions":"","customAnnotations":{"deployment":{},"destinationRule":{},"horizontalPodAutoscaler":{},"pod":{},"podDisruptionBudget":{},"secret":{},"service":{},"virtualService":{}},"enabled":true,"ingress":{"casaAdditionalAnnotations":{},"casaEnabled":false,"casaLabels":{}}},"cleanup":{"enabled":true},"cloud":{"testEnviroment":false},"cnAwsConfigFile":"/etc/jans/conf/aws_config_file","cnAwsSecretsReplicaRegionsFile":"/etc/jans/conf/aws_secrets_replica_regions","cnAwsSharedCredentialsFile":"/etc/jans/conf/aws_shared_credential_file","cnConfiguratorConfigurationFile":"/etc/jans/conf/configuration.json","cnConfiguratorCustomSchema":{"secretName":""},"cnConfiguratorDumpFile":"/etc/jans/conf/configuration.out.json","cnConfiguratorKey":"","cnConfiguratorKeyFile":"/etc/jans/conf/configuration.key","cnDocumentStoreType":"DB","cnGoogleApplicationCredentials":"/etc/jans/conf/google-credentials.json","cnObExtSigningAlias":"","cnObExtSigningJwksCrt":"","cnObExtSigningJwksKey":"","cnObExtSigningJwksKeyPassPhrase":"","cnObExtSigningJwksUri":"","cnObStaticSigningKeyKid":"","cnObTransportAlias":"","cnObTransportCrt":"","cnObTransportKey":"","cnObTransportKeyPassPhrase":"","cnObTransportTrustStore":"","cnPersistenceType":"sql","cnPrometheusPort":"","cnSqlPasswordFile":"/etc/jans/conf/sql_password","config":{"customAnnotations":{"clusterRoleBinding":{},"configMap":{},"job":{},"role":{},"roleBinding":{},"secret":{},"service":{},"serviceAccount":{}},"enabled":true},"config-api":{"adminUiAppLoggers":{"adminUiAuditLogLevel":"INFO","adminUiAuditLogTarget":"FILE","adminUiLogLevel":"INFO","adminUiLogTarget":"FILE","enableStdoutLogPrefix":"true"},"appLoggers":{"configApiLogLevel":"INFO","configApiLogTarget":"STDOUT","enableStdoutLogPrefix":"true","persistenceDurationLogLevel":"INFO","persistenceDurationLogTarget":"FILE","persistenceLogLevel":"INFO","persistenceLogTarget":"FILE","scriptLogLevel":"INFO","scriptLogTarget":"FILE"},"cnCustomJavaOptions":"","configApiServerServiceName":"config-api","customAnnotations":{"deployment":{},"destinationRule":{},"horizontalPodAutoscaler":{},"pod":{},"podDisruptionBudget":{},"service":{},"virtualService":{}},"enabled":true,"ingress":{"configApiAdditionalAnnotations":{},"configApiEnabled":true,"configApiLabels":{}},"plugins":"admin-ui,fido2,scim,user-mgt"},"configAdapterName":"kubernetes","configSecretAdapter":"kubernetes","distribution":"default","fido2":{"appLoggers":{"enableStdoutLogPrefix":"true","fido2LogLevel":"INFO","fido2LogTarget":"STDOUT","persistenceDurationLogLevel":"INFO","persistenceDurationLogTarget":"FILE","persistenceLogLevel":"INFO","persistenceLogTarget":"FILE","scriptLogLevel":"INFO","scriptLogTarget":"FILE"},"cnCustomJavaOptions":"","customAnnotations":{"deployment":{},"destinationRule":{},"horizontalPodAutoscaler":{},"pod":{},"podDisruptionBudget":{},"secret":{},"service":{},"virtualService":{}},"enabled":true,"fido2ServiceName":"fido2","ingress":{"fido2AdditionalAnnotations":{},"fido2ConfigAdditionalAnnotations":{},"fido2ConfigEnabled":false,"fido2ConfigLabels":{},"fido2Enabled":false,"fido2Labels":{},"fido2WebauthnAdditionalAnnotations":{},"fido2WebauthnEnabled":false,"fido2WebauthnLabels":{}}},"fqdn":"demoexample.gluu.org","gcePdStorageType":"pd-standard","isFqdnRegistered":false,"istio":{"additionalAnnotations":{},"additionalLabels":{},"enabled":false,"gateways":[],"ingress":false,"namespace":"istio-system"},"jobTtlSecondsAfterFinished":300,"kc-scheduler":{"enabled":false},"lbIp":"22.22.22.22","nginx-ingress":{"enabled":true},"persistence":{"customAnnotations":{"job":{},"secret":{},"service":{}},"enabled":true},"saml":{"cnCustomJavaOptions":"","customAnnotations":{"deployment":{},"destinationRule":{},"horizontalPodAutoscaler":{},"pod":{},"podDisruptionBudget":{},"secret":{},"service":{},"virtualService":{}},"enabled":false,"ingress":{"samlAdditionalAnnotations":{},"samlEnabled":false,"samlLabels":{}},"samlServiceName":"saml"},"scim":{"appLoggers":{"enableStdoutLogPrefix":"true","persistenceDurationLogLevel":"INFO","persistenceDurationLogTarget":"FILE","persistenceLogLevel":"INFO","persistenceLogTarget":"FILE","scimLogLevel":"INFO","scimLogTarget":"STDOUT","scriptLogLevel":"INFO","scriptLogTarget":"FILE"},"cnCustomJavaOptions":"","customAnnotations":{"deployment":{},"destinationRule":{},"horizontalPodAutoscaler":{},"pod":{},"podDisruptionBudget":{},"secret":{},"service":{},"virtualService":{}},"enabled":true,"ingress":{"scimAdditionalAnnotations":{},"scimConfigAdditionalAnnotations":{},"scimConfigEnabled":false,"scimConfigLabels":{},"scimEnabled":false,"scimLabels":{}},"scimServiceName":"scim"},"serviceAccountName":"default","storageClass":{"allowVolumeExpansion":true,"allowedTopologies":[],"mountOptions":["debug"],"parameters":{},"provisioner":"microk8s.io/hostpath","reclaimPolicy":"Retain","volumeBindingMode":"WaitForFirstConsumer"},"usrEnvs":{"normal":{},"secret":{}}}` | Parameters used globally across all services helm charts. | | ||
| | gatewayApi.gatewayAnnotations | object | `{}` | Specific annotations for the Gateway resource | | ||
| | gatewayApi.gatewayClassName | string | `"nginx"` | Set the gatewayClassName corresponding to your installed controller. We support all GA-conformant implementations(e.g., 'nginx', 'istio', 'cilium', 'traefik'). See https://gateway-api.sigs.k8s.io/implementations/#conformant | |
Contributor
There was a problem hiding this comment.
Wrap the bare URL to satisfy markdownlint (MD034).
✅ Suggested fix
-| gatewayApi.gatewayClassName | string | `"nginx"` | Set the gatewayClassName corresponding to your installed controller. We support all GA-conformant implementations(e.g., 'nginx', 'istio', 'cilium', 'traefik'). See https://gateway-api.sigs.k8s.io/implementations/#conformant |
+| gatewayApi.gatewayClassName | string | `"nginx"` | Set the gatewayClassName corresponding to your installed controller. We support all GA-conformant implementations(e.g., 'nginx', 'istio', 'cilium', 'traefik'). See <https://gateway-api.sigs.k8s.io/implementations/#conformant> |📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| | gatewayApi.gatewayClassName | string | `"nginx"` | Set the gatewayClassName corresponding to your installed controller. We support all GA-conformant implementations(e.g., 'nginx', 'istio', 'cilium', 'traefik'). See https://gateway-api.sigs.k8s.io/implementations/#conformant | | |
| | gatewayApi.gatewayClassName | string | `"nginx"` | Set the gatewayClassName corresponding to your installed controller. We support all GA-conformant implementations(e.g., 'nginx', 'istio', 'cilium', 'traefik'). See <https://gateway-api.sigs.k8s.io/implementations/#conformant> | |
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
347-347: Bare URL used
(MD034, no-bare-urls)
🤖 Prompt for AI Agents
In `@docs/reference/kubernetes/helm-chart.md` at line 347, The bare URL in the
table cell for gatewayApi.gatewayClassName violates markdownlint MD034; update
that table row (the cell containing "See
https://gateway-api.sigs.k8s.io/implementations/#conformant") to wrap the URL so
it's not a bare URL — e.g., enclose it in angle brackets or convert it to a
markdown link — ensuring the rest of the row text remains unchanged.
iromli
approved these changes
Jan 22, 2026
duttarnab
approved these changes
Jan 23, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare release for 5.16.0
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.