Skip to content

지정견적 리스트는 메이커의 지역과 상관 없이 필터되지 않도록 수정 #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Maybeiley merged 1 commit into from
Feb 22, 2025
Merged

지정견적 리스트는 메이커의 지역과 상관 없이 필터되지 않도록 수정 #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/common/constants/errorMessage.enum.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export enum ErrorMessage {
PLAN_READY_TO_REVIEW_BAD_REQUEST = '완료할 수 있는 플랜 필터링은 CONFIRMED 상태만 가능합니다.',
PLAN_REVIEW_FILTER_BAD_REQUEST = '리뷰는 OVERDUE와 PENDING 상태의 플랜에는 있을 수 없습니다.',
PLAN_DELETE_BAD_REQUEST = 'CONFIRMED 상태의 진행중인 플랜은 삭제할 수 없습니다.',
PLAN_IS_ASSIGNED_BAD_REQUEST = 'IS_ASSIGNED 값은 true와 false 혹은 입력하지 않아야 합니다.',
PLAN_IS_ASSIGNED_BAD_REQUEST = 'isAssigned 쿼리의 값은 true와 false 혹은 쿼리를입력하지 않아야 합니다.',
PLAN_CANNOT_CREATE_CHATROOM_BAD_REQUEST = '해당 플랜은 채팅방을 만들 수 없습니다. CONFIRMED상태의 플랜만 가능합니다.',
PLAN_MAKER_NOT_IN_SERVICE_AREA = '메이커의 서비스지역이 플랜의 서비스지역과 일치하지 않습니다.',

Expand Down
3 changes: 1 addition & 2 deletions src/modules/plan/plan.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ export default class PlanService {
options: PlanQueryOptions
): Promise<{ totalCount: number; groupByCount: GroupByCount; list: PlanToClientProperties[] }> {
const makerProfile = await this.userService.getProfile(RoleValues.MAKER, userId);

const serviceArea: ServiceArea[] = makerProfile.serviceArea;
const serviceArea: ServiceArea[] = options.isAssigned === true ? undefined : makerProfile.serviceArea;

options.serviceArea = serviceArea; //NOTE. 메이커의 서비스지역 필터링
options.userId = userId;
Expand Down