Skip to content

플랜 완료시 채팅방이 존재하지 않아 생기는 에러 해결 #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Maybeiley merged 1 commit into from
Feb 22, 2025
Merged

플랜 완료시 채팅방이 존재하지 않아 생기는 에러 해결 #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/modules/chatRoom/chatRoom.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,11 +121,13 @@ export default class ChatRoomService {
return chatData;
}

@Transactional()
async deActive(planId: string): Promise<void> {
const chatRoom = await this.getChatRoomDomain({ planId });
chatRoom.update();
await this.chatRoomRepository.update(chatRoom);
const chatRoom = await this.chatRoomRepository.findChatRoom({ planId });
//NOTE. 일단 임시로 트랜젝션을 제외
if (chatRoom) {
chatRoom.update();
await this.chatRoomRepository.update(chatRoom);
} //NOTE. 채팅방 목데이터가 없어서 나는 에러 처리
}

async deActiveMany(planIds: string[]): Promise<void> {
Expand Down
2 changes: 1 addition & 1 deletion src/modules/plan/plan.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,8 +231,8 @@ export default class PlanService {
plan.updateComplete();
const updatedPlan = await this.repository.update(plan);
const planId = plan.getId();
await this.chatRoomService.deActive(planId);

await this.chatRoomService.deActive(planId);
await this.pointQueue.add('points', {
userId: plan.getConfirmedMakerId(),
event: PointEventEnum.EARN,
Expand Down