Skip to content

User 닉네임 수정 오류 해결#268

Merged
Maybeiley merged 3 commits intodevfrom
Feat/#266-fix-user-update-nickname
Feb 23, 2025
Merged

User 닉네임 수정 오류 해결#268
Maybeiley merged 3 commits intodevfrom
Feat/#266-fix-user-update-nickname

Conversation

@Maybeiley
Copy link
Contributor

작업한 이슈 번호

작업 사항 설명

User 테스트 코드 작성 할 때 추가한 닉네임 수정 예외 처리에 오류가 있어 수정합니다.
프론트엔드 요청으로 에러 메시지 내용 수정 반영했습니다.

작업 사항

  • User 닉네임 수정 오류 해결(promise)

기타

@Maybeiley Maybeiley added the 버그 Something isn't working label Feb 23, 2025
@Maybeiley Maybeiley self-assigned this Feb 23, 2025
Comment on lines 61 to 66

if (data.nickName) {
const existNickName = this.repository.findByNickName(data.nickName);
if (data.nickName && data.nickName !== user.getNickName()) {
const existNickName = await this.repository.findByNickName(data.nickName);
console.log(typeof existNickName, existNickName);
if (existNickName) {
throw new BadRequestError(ErrorMessage.USER_NICKNAME_EXIST);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

콘솔로그 남았어요

@Maybeiley Maybeiley merged commit 335c747 into dev Feb 23, 2025
1 check passed
@Maybeiley Maybeiley deleted the Feat/#266-fix-user-update-nickname branch February 24, 2025 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

버그 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

User 닉네임 수정 오류 해결

2 participants