Conversation
Comment on lines
+43
to
+49
| ) { | ||
| if (role === 'DREAMER') { | ||
| return await this.service.updateDreamerProfile(userId, data); | ||
| } | ||
| return await this.service.updateMakerProfile(userId, data); | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
앗, 예전 코드 그대로 가져오다보니 ㅠㅠ 수정해서 올릴게요~
Comment on lines
+13
to
+21
| async getProfile(role: string, userId: string): Promise<DreamerProfileProperties | MakerProfileProperties> { | ||
| if (role === 'DREAMER') { | ||
| const profile = await this.repository.findDreamerProfile(userId); | ||
| return profile.get(); | ||
| } | ||
|
|
||
| const profile = await this.repository.findMakerProfile(userId); | ||
| return profile.get(); | ||
| } |
Comment on lines
+11
to
+21
| async findDreamerProfile(userId: string): Promise<IDreamerProfile> { | ||
| const data = await this.db.dreamerProfile.findUnique({ | ||
| where: { | ||
| userId | ||
| } | ||
| }); | ||
|
|
||
| if (data) { | ||
| return new DreamerProfileMapper(data).toDomain(); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
저희 지금까지 해온거는 레포에서는 리턴해주고 맵퍼에서 없는걸 처리해주지 않나요?
Contributor
Author
There was a problem hiding this comment.
ㅋㅋㅋㅋ 초기에 만든거라 그렇네요 ㅋㅋㅋ 수정하겠습니다~!
taeyeonkim94
approved these changes
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업한 이슈 번호
작업 사항 설명
현재 User, Auth 모듈에서 사용하는 Profile 관련 메서드를 Profile 모듈로 분리합니다.
작업 사항
기타