manuelhurtado: LoR demo #99
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lsubatin
reviewed
Jul 28, 2025
| @@ -0,0 +1,8 @@ | |||
| { | |||
| "/api/*": { | |||
| "target": "https://spanner-lor-40332330336.europe-southwest1.run.app", | |||
Collaborator
There was a problem hiding this comment.
should this be retrieved from cloud run or set as an env var?
Lsubatin
reviewed
Jul 28, 2025
Collaborator
Lsubatin
left a comment
Lsubatin
left a comment
There was a problem hiding this comment.
Thanks! waiting on headers and I'll merge. Added a single comment on the target for the backend in Cloud Run
Collaborator
|
Also, could we please add a file called SAMPLEOWNERS with your github ID in it? |
Contributor
Author
|
Good catch! This file is only used for local testing. This is not used in
the demo deployed following the instructions.
El lun, 28 jul 2025 a las 21:11, Lucia Subatin ***@***.***>)
escribió:
… ***@***.**** commented on this pull request.
------------------------------
In lor/web-lor/src/proxy.config_CRUN.json
<#99 (comment)>
:
> @@ -0,0 +1,8 @@
+{
+ "/api/*": {
+ "target": "https://spanner-lor-40332330336.europe-southwest1.run.app",
should this be retrieved from cloud run or set as an env var?
—
Reply to this email directly, view it on GitHub
<#99 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADMK4IUXI64LRDGBYMJ7I5L3KZYXNAVCNFSM6AAAAACCRNCRDWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTANRUGI4DKNJZGU>
.
You are receiving this because you authored the thread.Message ID:
<GoogleCloudPlatform/cloud-spanner-samples/pull/99/review/3064285595@
github.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LoR Spanner Graph demo