Open
Conversation
fba0d3a to
f79df48
Compare
franciscovalentecastro
approved these changes
Mar 16, 2026
Contributor
franciscovalentecastro
left a comment
There was a problem hiding this comment.
LGTM!
As a suggestion (which may not be worth it) we could integrate the Otel Logging persistence into the existing TestBufferLimitSizeOpsAgent test which verifies the size of fluent-bit persistence.
ridwanmsharif
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Using a file_storage for persistent logs allows us to survive network outages by storing in-flight logs on disk.
Also, because
googlecloudexporterretries happen inside gRPC, we need to bump the RPC timeout up to 3600s or else the logs and just dropped at 60s anyway.Related issue
b/491197162
How has this been tested?
Manually tested the generated config on a test VM; will also check the integration tests on this PR.
Checklist: