-
Notifications
You must be signed in to change notification settings - Fork 101
fix: update out of sync Prometheus image #1789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/0.17
Are you sure you want to change the base?
Conversation
46f589a to
06f35ed
Compare
examples/prometheus.yaml
Outdated
| - name: prometheus-db | ||
| mountPath: /prometheus/data | ||
| - name: config-reloader | ||
| image: gke.gcr.io/prometheus-engine/config-reloader:v0.12.0-gke.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is ideally bumped too, as mentioned in https://github.com/GoogleCloudPlatform/prometheus-engine/pull/1786/files#r2461450478
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we quickly hook it with /charts while we are here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, added some comments. Also not sure if docs should link to unreleased 0.17 branch/release at the moment or should we just use main. Let's chat
Also please update commit msg, that's why conform is complaining.
FYI, have you seen #1786?
Nevertheless let's converge to something that will work for docs. I'd say .6 image with config-reloader bump and doing this on 0.15 release might be best for now (let's discuss in gchat), but I wonder if there's a room for special branch for docs or at least minimal templating for basics like config-reloader version.
examples/prometheus.yaml
Outdated
| containers: | ||
| - name: prometheus | ||
| image: gke.gcr.io/prometheus-engine/prometheus:v2.45.3-gmp.7-gke.0 | ||
| image: gke.gcr.io/prometheus-engine/prometheus:v2.53.5-gmp.0-gke.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the issue, as mentioned in our docs, is the unfortunate cycle: Our repos is the source for building but also contain examples and outputs to use ONCE things are built and deployed. This image does not exists until we release things to GKE. Louhi flow only builds to staging. This is a major pain, but there's not much we can do, unless we want to show staging here OR some automation for creating PRs once we have GKE prod images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking on prod registry, I see .6 which is probably the best we can share now.
| image: gke.gcr.io/prometheus-engine/prometheus:v2.53.5-gmp.0-gke.8 | |
| image: gke.gcr.io/prometheus-engine/prometheus:v2.53.5-gmp.0-gke.6 |
2778fee to
3564788
Compare
The prometheus image in the example directory should be kept in sync with the one used by the 0.17 branch Signed-off-by: Henrique Matulis <hmatulis@google.com>
3564788 to
78bde6c
Compare
The prometheus image in the example directory should be kept in sync with the one used by the 0.17 branch