Removed explicit dependency to logging plugin so people can change the logging framework#1
Open
fterrier wants to merge 1 commit intoGrailsrocks:masterfrom
Open
Removed explicit dependency to logging plugin so people can change the logging framework#1fterrier wants to merge 1 commit intoGrailsrocks:masterfrom
fterrier wants to merge 1 commit intoGrailsrocks:masterfrom
Conversation
|
Any idea why this patch hasn't been merge? I also need this, is this plugin still maintain? |
|
Hi, |
|
Yes, and make a little release of it so we can update from central. Please, please, please |
|
+1, for the grails logback plugin - http://grails.org/plugin/logback |
|
+1. This is a major problem for us. |
|
It has been merged into https://github.com/grails-plugins/grails-cache-headers which is the new home for cache-headers |
rosenfeld
pushed a commit
to rosenfeld/grails-cache-headers
that referenced
this pull request
Oct 16, 2013
Removed explicit dependency to logging plugin so people can change the logging framework
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When following the instructions in the Grails guide (http://grails.org/doc/2.0.x/guide/conf.html#logging), run-app fails because of that explicit dependency.
To reproduce, add to an app using the cache-headers plugin:
...
inherits("global") {
excludes "grails-plugin-logging", "log4j"
}
…
and then grails run-app