Open
Conversation
Member
blackbracken
left a comment
blackbracken
left a comment
There was a problem hiding this comment.
少し多くなってしまいましたがレビューしました
基本non-nullableにすることを心掛けるとより良いコードが書けるようになると思います
otherwise LGTM.
ryo-ymd
reviewed
Apr 14, 2019
ryo-ymd
reviewed
Apr 14, 2019
ryo-ymd
reviewed
Apr 14, 2019
ryo-ymd
reviewed
Apr 14, 2019
|
|
||
| import java.util.* | ||
|
|
||
| class Guild(val masterUUID: UUID, val memberUUIDList: List<UUID>, val name: String) |
Collaborator
Author
There was a problem hiding this comment.
とりあえずないとつらいから書いた
Member
There was a problem hiding this comment.
とりあえずで各プラグインに書いたクラスをあとでコアに移植するのと、
そもそもの使い方を事前にバチっと決めて最初にコアにクラス宣言しておくのどっちが楽か迷っているなう
Member
|
このPRコメント多くて引くｗｗ |
taktakahashi
force-pushed
the
feature/cyc_2_create_guild
branch
from
a3a694d to
8478e49
Compare
| "INIT" -> { | ||
| guildContainer.createGuild(senderPlayer?.uniqueId, args[1]) | ||
| true | ||
| if (args[1].isNullOrBlank()) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/sarcandra-guild init {guildName}ギルド作成 一人につき一つまで/sarcandra-guild dissolveギルド解散