Open
Conversation
Contributor
Author
|
Contributor
Author
|
YoniKiriaty
requested changes
Feb 4, 2026
apps/scouting/frontend/src/strategy/datasets.ts/test-dataset.ts
Outdated
Show resolved
Hide resolved
apps/scouting/frontend/src/strategy/data-templates-for-charts.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+2
to
+6
| export interface DataSet<T extends string | number> { | ||
| name: string; | ||
| points: Record<T, number>; | ||
| color?: string; //assign color if not defined | ||
| } |
Contributor
There was a problem hiding this comment.
consider renaming this file DataSet or something
YoniKiriaty
requested changes
Feb 4, 2026
Comment on lines
+2
to
+6
| export interface DataSet<T extends string | number> { | ||
| name: string; | ||
| points: Record<T, number>; | ||
| color?: string; //assign color if not defined | ||
| } |
YoniKiriaty
reviewed
Feb 4, 2026
Contributor
There was a problem hiding this comment.
don't really see a reason for this to be named a template
yoavs8
approved these changes
Feb 4, 2026
| const defaultColors = ["blue", "red", "violet", "orange"]; | ||
|
|
||
| const labels = Array.from( | ||
| new Set(dataSetsProps.flatMap((ds) => Object.keys(ds.points))), |
Contributor
There was a problem hiding this comment.
Suggested change
| new Set(dataSetsProps.flatMap((ds) => Object.keys(ds.points))), | |
| new Set(dataSetsProps.flatMap((dataSet) => Object.keys(ds.points))), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generating either a line chart or a pie chart according to a convinient dataset template