Conversation
Implements customer domain enumerations from customer.xsd with proper JAXB/Jakarta XML binding annotations and comprehensive XSD documentation. Customer Domain Enums: - CustomerKind (15 values) - Customer classifications (residential, commercialIndustrial, etc.) - SupplierKind (6 values) - Supplier types (utility, retailer, lse, mdma, msp, other) - ServiceKind (11 values) - Service types (electricity, gas, water, heat, etc.) - EnrollmentStatus (3 values) - DR program enrollment status (unenrolled, enrolled, enrolledPending) - NotificationMethodKind (5 values) - Notification methods (call, email, letter, ivr, other) - MeterMultiplierKind (6 values) - Meter multiplier types (kH, transformerRatio, kR, kE, ctRatio, ptRatio) - RevenueKind (7 values) - Revenue classifications (residential, commercial, industrial, etc.) - ProgramDateKind (4 values) - DR program date types - CRUDOperation (4 values) - CRUD operations (0=CREATE, 1=READ, 2=UPDATE, 3=DELETE) - MediaType (16 values) - IANA media types (application/json, application/pdf, text/csv, etc.) All enums include: - Apache License 2.0 header (copyright 2025 Green Button Alliance, Inc.) - Package: org.greenbuttonalliance.espi.common.domain.customer.enums - JAXB/Jakarta XML binding annotations (@XmlType with namespace="http://naesb.org/espi/customer") - getValue() and fromValue() methods with IllegalArgumentException for invalid values - Comprehensive Javadoc from XSD documentation with line numbers - Type-safe enum constants (String or int based on XSD type) Test Updates: - Updated CustomerKind test values: COMMERCIAL → COMMERCIAL_INDUSTRIAL per XSD - Updated SupplierKind test values: uppercase → lowercase per XSD - Updated CustomerKind test values: uppercase → lowercase per XSD Total enum values in batch: 77 Per ESPI 4.0 specification (NAESB REQ.21) All tests: 781/781 passed ✓ - Unit tests: 638/638 passed - Integration tests: 143/143 passed (with Docker/TestContainers) Related to #101 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements customer domain enumerations from customer.xsd with proper JAXB/Jakarta XML binding annotations and comprehensive XSD documentation.
Customer Domain Enums (10 enums, 77 total values):
Implementation Details
All enums include:
org.greenbuttonalliance.espi.common.domain.customer.enums@XmlTypewithnamespace="http://naesb.org/espi/customer")getValue()andfromValue()methods withIllegalArgumentExceptionfor invalid valuesTest Updates
Updated test files to use XSD-compliant enum values:
COMMERCIAL→COMMERCIAL_INDUSTRIALTesting
Schema Compliance
Per ESPI 4.0 specification (NAESB REQ.21) customer.xsd:
Related to #101
🤖 Generated with Claude Code