Fixed news source selection crashing with incorrect inputs#20
Open
VilleKemp wants to merge 1 commit intoGriffintaur:masterfrom
Open
Fixed news source selection crashing with incorrect inputs#20VilleKemp wants to merge 1 commit intoGriffintaur:masterfrom
VilleKemp wants to merge 1 commit intoGriffintaur:masterfrom
Conversation
Griffintaur
reviewed
Oct 29, 2017
Owner
Griffintaur
left a comment
Griffintaur
left a comment
There was a problem hiding this comment.
can you add more details in the issue .I don't understand why it was crashing?
Owner
|
@VilleKemp any update on issue .is it reproducible? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
News source selection was crashing with inputs that are larger than the lists index or with non-integer values.