Feat/multi node #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR implements multi-node support for the kube-prometheus-stack Helm chart by introducing new templates and helper functions for monitoring Kubernetes control plane components. The changes primarily focus on adding ServiceMonitor and Service configurations for kube-controller-manager, kube-api-server, and CoreDNS, along with comprehensive alertmanager and grafana chart dependencies.
Key Changes:
- Added monitoring templates for Kubernetes control plane components (kube-controller-manager, kube-api-server, CoreDNS)
- Introduced complete alertmanager resource templates (service, servicemonitor, routes, secrets, etc.)
- Added full Grafana chart dependency with all necessary templates
- Included prometheus-node-exporter and prometheus-windows-exporter charts as dependencies
- Added kube-state-metrics chart for cluster-level metrics
Reviewed changes
Copilot reviewed 156 out of 321 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| kube-controller-manager templates | ServiceMonitor, Service, and Endpoints configurations for monitoring controller manager |
| kube-api-server/servicemonitor.yaml | ServiceMonitor for API server metrics collection |
| core-dns templates | Service and ServiceMonitor for CoreDNS monitoring |
| alertmanager/* | Complete alertmanager deployment including services, routes, secrets, and monitoring |
| grafana/* | Full Grafana chart with services, deployments, tests, and configuration |
| prometheus-node-exporter/* | Node exporter chart for hardware/OS metrics |
| prometheus-windows-exporter/* | Windows-specific exporter chart |
| kube-state-metrics/* | Chart for Kubernetes object state metrics |
| _helpers.tpl | Helper template functions for naming and configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.