Skip to content

Fix dialtesting log 1104 #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coanor merged 3 commits into from
Dec 17, 2025
Merged

Fix dialtesting log 1104 #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4abf8ba
save
Nov 4, 2025
656728d
Merge branch 'main' into fix-dialtesting-log-1104
Nov 25, 2025
e154804
save
Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion dialtesting/icmp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,6 @@ func doPing(timeout time.Duration, target string) (rtt time.Duration, err error)
}
if err != nil {
if nerr, ok := err.(net.Error); ok && nerr.Timeout() { // nolint: errorlint
logger.Debugf("timeout reading from socket: %s", err.Error())
return 0, nil
}
return 0, fmt.Errorf("error reading from socket: %w", err)
Expand Down
1 change: 1 addition & 0 deletions dialtesting/task.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ type ITask interface {
ID() string
Status() string
Run() error
Clear()
CheckResult() ([]string, bool)
Class() string
GetResults() (map[string]string, map[string]interface{})
Expand Down