Diskcache better error and lock metrics #176
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add CacheError struct with operation context, file paths, and detailed information - Implement comprehensive error wrapping for all diskcache operations - Add IsRetryable() function for intelligent error recovery decisions - Include GetErrorContext() for structured error analysis and debugging - Update error handling across all modules: put, get, rotate, open, switch, pos, lock, drop - Preserve backward compatibility with existing error types via unwrapping - Add comprehensive test suite for enhanced error scenarios - Improve debugging with caller information and operation-specific details Key improvements: - Errors now include operation type (Put, Get, Rotate, etc.) - File and path context for better issue localization - Detailed error messages with sizes, positions, and state information - Retryable error detection for robust error handling - Structured error context for programmatic analysis
- Add instrumented mutexes to track lock contention events - Add histogram metric for lock wait times by lock type and path - Add counter metric for total lock contention events - Include comprehensive documentation and unit tests - Replace sync.Mutex with InstrumentedMutex in DiskCache struct - Initialize instrumented locks after cache path is known
|
|
coanor
force-pushed
the
diskcache-better-error
branch
from
12688cd to
c9815b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.