-
Notifications
You must be signed in to change notification settings - Fork 68
Create PseudoRiemannian #501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This PR is divided in 3 parts. Next is Riemannian Metric (with implementation) and then is Levi-Civita Connection
|
after completing the PR I will ask for feedback/criticisms in Zulip |
TODO: add InnerProductSpace to complete the section
smoothness is now defined locally as a predicate added constant index condition (cfr O'Neill 'Semi-Riemannian Geometry p 54,55) Removed RCLike as it should not be needed for general relativity or QFT InnerProductSpace is defined locally instead of as a global instance
PhysLean/Mathematics/Geometry/Metric/PseudoRiemannian/Defs.lean
Outdated
Show resolved
Hide resolved
PhysLean/Mathematics/Geometry/Metric/PseudoRiemannian/Defs.lean
Outdated
Show resolved
Hide resolved
PhysLean/Mathematics/Geometry/Metric/PseudoRiemannian/Defs.lean
Outdated
Show resolved
Hide resolved
PhysLean/Mathematics/Geometry/Metric/PseudoRiemannian/Defs.lean
Outdated
Show resolved
Hide resolved
PhysLean/Mathematics/Geometry/Metric/PseudoRiemannian/Defs.lean
Outdated
Show resolved
Hide resolved
PhysLean/Mathematics/Geometry/Metric/PseudoRiemannian/Defs.lean
Outdated
Show resolved
Hide resolved
|
|
||
| import PhysLean.Mathematics.Geometry.Metric.PseudoRiemannian.Defs | ||
| import Mathlib.LinearAlgebra.QuadraticForm.Dual | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove this space. Maybe run #min_imports at the bottom of the file aswell to minimize the imports needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I forgot to update it after running #min_imports on PseudoRiemannian :)
PhysLean/Mathematics/Geometry/Metric/PseudoRiemannian/Defs.lean
Outdated
Show resolved
Hide resolved
|
I tried to download your branch to experiment with things - but I think it is still on an older version of lean and mathlib If you want to update I think you can:
(which might take ~20min depending on your computer) |
|
I've dealt with the instances - let me know if you strongly disagree with my changes. Won't make any more changes for the time-being. |
PhysLean/Mathematics/Geometry/Metric/PseudoRiemannian/Defs.lean
Outdated
Show resolved
Hide resolved
PhysLean/Mathematics/Geometry/Metric/PseudoRiemannian/Defs.lean
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what this has to do with Riemannian metrics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@or4nge19 I think we can probably revert this change, right? It is probably overhang from the different versions of Mathlib.
But yes @idontgetoutmuch - this has nothing to do with Riemannian metrics :).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it's because i forgot to update to the latest mathlib version. I had t replace some deprecated lemmas to make the PhysLean.lean main file compile with the Riemannian PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will revert!
Revert "merge"
|
I fixed the reverts. Basically I ran locally the following commands: on the affected files. The following comments still need addressing:
|
|
Thanks! |
fixed last review suggestions
|
have added PseudoRiemannian/Chart.lean and relative submodules. This defines |
This PR is divided in 2 parts. Next is Riemannian Metric (with implementation)