Skip to content

Conversation

@or4nge19
Copy link
Collaborator

@or4nge19 or4nge19 commented Apr 18, 2025

This PR is divided in 2 parts. Next is Riemannian Metric (with implementation)

This PR is divided in 3 parts. Next is Riemannian Metric (with implementation) and then is Levi-Civita Connection
@or4nge19
Copy link
Collaborator Author

after completing the PR I will ask for feedback/criticisms in Zulip

@or4nge19 or4nge19 marked this pull request as draft April 24, 2025 15:17
smoothness is now defined locally as a predicate
added constant index condition (cfr O'Neill 'Semi-Riemannian Geometry p 54,55)
Removed RCLike as it should not be needed for general relativity or QFT
InnerProductSpace is defined locally instead of as a global instance
@or4nge19 or4nge19 marked this pull request as ready for review April 29, 2025 00:56
@or4nge19
Copy link
Collaborator Author


import PhysLean.Mathematics.Geometry.Metric.PseudoRiemannian.Defs
import Mathlib.LinearAlgebra.QuadraticForm.Dual

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this space. Maybe run #min_imports at the bottom of the file aswell to minimize the imports needed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I forgot to update it after running #min_imports on PseudoRiemannian :)

@jstoobysmith
Copy link
Member

I tried to download your branch to experiment with things - but I think it is still on an older version of lean and mathlib
(which might be why the instances are needed).

If you want to update I think you can:

  1. merge Master into this branch.
  2. run:
rm -rf .lake  ;  lake update ;   lake exe cache get ;   lake build 

(which might take ~20min depending on your computer)

@jstoobysmith
Copy link
Member

I've dealt with the instances - let me know if you strongly disagree with my changes. Won't make any more changes for the time-being.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what this has to do with Riemannian metrics.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@or4nge19 I think we can probably revert this change, right? It is probably overhang from the different versions of Mathlib.

But yes @idontgetoutmuch - this has nothing to do with Riemannian metrics :).

Copy link
Collaborator Author

@or4nge19 or4nge19 Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it's because i forgot to update to the latest mathlib version. I had t replace some deprecated lemmas to make the PhysLean.lean main file compile with the Riemannian PR

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will revert!

@jstoobysmith
Copy link
Member

jstoobysmith commented May 2, 2025

I fixed the reverts.

Basically I ran locally the following commands:

git checkout Master -- ./PhysLean/StringTheory/FTheory/SU5U1/PhenoConstraints/Basic.lean

on the affected files.

The following comments still need addressing:

@or4nge19
Copy link
Collaborator Author

or4nge19 commented May 2, 2025

Thanks!

@or4nge19
Copy link
Collaborator Author

or4nge19 commented May 9, 2025

have added PseudoRiemannian/Chart.lean and relative submodules. This defines chartMetric, which expresses a pseudo-Riemannian metric in local chart coordinates, and proves its transformation properties under coordinate changes. Next file in the PseudoRiemannian namespace will prove the equivalence: smooth_in_charts_iff_contDiffOn

or4nge19 added a commit that referenced this pull request May 14, 2025
no change from #501
or4nge19 added a commit that referenced this pull request May 14, 2025
fixed lints from #501
or4nge19 added a commit that referenced this pull request May 22, 2025
@or4nge19 or4nge19 marked this pull request as draft May 22, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants