Open
Conversation
Co-authored-by: HNygard <168380+HNygard@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix sorting functionality for thread list
Fix thread list sorting with active filters
Jan 26, 2026
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where clicking the "Last email" column header in the thread list would toggle the sort indicator but fail to reorder rows when filters were active. The root cause was that the sorting code was re-appending all rows (including hidden ones), which inadvertently made filtered rows visible again.
Changes:
- Modified
tableSorting.jsto partition rows into visible and hidden before sorting - Sort operation now only reorders visible rows while preserving hidden rows at the end
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Clicking the "Last email" column header toggles the sort indicator but doesn't reorder rows when filters are active.
Root Cause
tableSearch.jshides filtered rows viadisplay: none. The sorting code was sorting all rows including hidden ones, then re-appending them to the DOM - which made hidden rows visible again, breaking the filter.Changes
Modified
organizer/src/webroot/js/tableSorting.jsto partition rows before sorting:Verification
Before filtering:

With filter applied:

Sorting while filtered (critical case):

Clear filter:

Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.