Adding ATMI as the runtime layer to launch Chapel's generated GPU ker…#13
Open
ashwinma wants to merge 10 commits intochpl-hsa-masterfrom
Open
Adding ATMI as the runtime layer to launch Chapel's generated GPU ker…#13ashwinma wants to merge 10 commits intochpl-hsa-masterfrom
ashwinma wants to merge 10 commits intochpl-hsa-masterfrom
Conversation
…led by setting the CHPL_TASKS to atmi instead of qthreads
…should be enabled to do that, but it is just conforming to the rest of our conditional compilation strategy anyway.
…e chpl-atmi null task instead of -1. Rationale to return 0 instead of chpl_nullTaskID: ATMI returns -1 as the NULL task, but we maintain 0 as the null task in chpl-atmi. Impl: chpl-atmi does not create a new task for the main wrapper. Instead it creates a dummy ATMI task in the beginning but does not launch/activate it. This helps us recognize 0 as the main/dummy task and not -1 that is expected by ATMI as the NULL task.
…esting of coforall and cobegin blocks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nels