Add cloudbuild.yaml for Google Cloud Build configuration#4432
Add cloudbuild.yaml for Google Cloud Build configuration#4432max-ostapenko wants to merge 7 commits intomainfrom
Conversation
| @@ -1,94 +0,0 @@ | |||
| ###################################### | |||
There was a problem hiding this comment.
Let's keep this for now, but disable it. Just until we get confidence this all works.
| push: | ||
| branches: | ||
| - main |
There was a problem hiding this comment.
Any reason not keep this? I kinda like it as a backup in case something is missed in a PR review.
There was a problem hiding this comment.
I had in mind that we need a complete sequential flow - if something fails to stop the deployment.
If we run one thing on GitHub and another on Cloud Build this doesn't happen.
So the idea is to migrate everything required to deployment workflow.
There was a problem hiding this comment.
Agree it's not needed. I just like it as an extra backup check so I can go into the Actions tab and see exactly when it started failing on the main branch. Similar to how we're seeing in har.fyi now.
Of course, ideally, it should never make it to main if it's going to cause an error. But sometimes things aren't caught in PRs...
So, while I agree it's not strictly necessary, and not part of the deploy process, I see no harm to keep it?
| push: | ||
| branches: | ||
| - main |
There was a problem hiding this comment.
Any reason not keep this? I kinda like it as a backup in case something is missed in a PR review.
Co-authored-by: Barry Pollard <barrypollard@google.com>
Co-authored-by: Barry Pollard <barrypollard@google.com>
2 participants
Added a deployment workflow draft - based on main push trigger.
Removed duplication with the existing GH actions.