Skip to content

Fix bug where empty node_tests executes complete test_suite #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexanderjeurissen merged 1 commit into from
Mar 21, 2021
Merged

Fix bug where empty node_tests executes complete test_suite #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/knapsack/runners/cucumber_runner.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ def self.run(args)
Knapsack.logger.info allocator.leftover_node_tests
Knapsack.logger.info

# NOTE: return if there are no specs to execute for this node.
# This can occurr if test_file_list_source_file is used with less then CI_NODES specs
return Knapsack.logger.warn('No specs to execute') if allocator.stringify_node_tests.empty?

cmd = %Q[bundle exec cucumber #{args} --require #{allocator.test_dir} -- #{allocator.stringify_node_tests}]

system(cmd)
Expand Down
4 changes: 4 additions & 0 deletions lib/knapsack/runners/minitest_runner.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ def self.run(args)
Knapsack.logger.info allocator.leftover_node_tests
Knapsack.logger.info

# NOTE: return if there are no specs to execute for this node.
# This can occurr if test_file_list_source_file is used with less then CI_NODES specs
return Knapsack.logger.warn('No specs to execute') if allocator.stringify_node_tests.empty?

task_name = 'knapsack:minitest_run'

if Rake::Task.task_defined?(task_name)
Expand Down
4 changes: 4 additions & 0 deletions lib/knapsack/runners/rspec_runner.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ def self.run(args)
Knapsack.logger.info allocator.leftover_node_tests
Knapsack.logger.info

# NOTE: return if there are no specs to execute for this node.
# This can occurr if test_file_list_source_file is used with less then CI_NODES specs
return Knapsack.logger.warn('No specs to execute') if allocator.stringify_node_tests.empty?

cmd = %Q[bundle exec rspec #{args} --default-path #{allocator.test_dir} -- #{allocator.stringify_node_tests}]

exec(cmd)
Expand Down
4 changes: 4 additions & 0 deletions lib/knapsack/runners/spinach_runner.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ def self.run(args)
Knapsack.logger.info allocator.leftover_node_tests
Knapsack.logger.info

# NOTE: return if there are no specs to execute for this node.
# This can occurr if test_file_list_source_file is used with less then CI_NODES specs
return Knapsack.logger.warn('No specs to execute') if allocator.stringify_node_tests.empty?

cmd = %Q[bundle exec spinach #{args} --features_path #{allocator.test_dir} -- #{allocator.stringify_node_tests}]

system(cmd)
Expand Down