Skip to content

Also use default behavior if test_file_list_source_file is empty #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexanderjeurissen wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Also use default behavior if test_file_list_source_file is empty #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82f1c63
Also use default behavior if test_file_list_source_file is empty
alexanderjeurissen Mar 26, 2021
217490c
Merge branch 'master' into add_selective_test_running_support
alexanderjeurissen Apr 20, 2021
7c47f46
Add puts, so we print out valuable knapsack info (even with log disab…
alexanderjeurissen Apr 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions lib/knapsack/distributors/base_distributor.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,17 @@ def all_tests
# support specifying a list_file to use similar to KnapsackPro
# ref: KnapsackPro/knapsack_pro-ruby/commit/7d7b8db8be524f2f30d7d80d3a6444dad9f85b1b
def test_files
return Dir.glob(test_file_pattern).uniq.sort if test_file_list_source_file.nil?
default = Dir.glob(test_file_pattern).uniq.sort

File.read(test_file_list_source_file)
return default if test_file_list_source_file.nil?

test_file_list = File.read(test_file_list_source_file)
.split(/\n/)
.uniq
.sort

return default if test_file_list.empty?
return test_file_list
end

protected
Expand Down
7 changes: 7 additions & 0 deletions lib/knapsack/runners/rspec_runner.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,19 @@ def self.run(args)
allocator = Knapsack::AllocatorBuilder.new(Knapsack::Adapters::RSpecAdapter).allocator

Knapsack.logger.info
puts ''
Knapsack.logger.info 'Report specs:'
puts 'Report specs:'
Knapsack.logger.info allocator.report_node_tests
puts allocator.report_node_tests
Knapsack.logger.info
puts ''
Knapsack.logger.info 'Leftover specs:'
puts 'Leftover specs:'
Knapsack.logger.info allocator.leftover_node_tests
puts allocator.leftover_node_tests
Knapsack.logger.info
puts

# NOTE: return if there are no specs to execute for this node.
# This can occurr if test_file_list_source_file is used with less then CI_NODES specs
Expand Down