Support reading with blocking sockets#24
Closed
arb000r wants to merge 1 commit intoHaveFunTrading:mainfrom
Closed
Conversation
Owner
|
hi @arb000r the issue is with tls stream implementation for I will look to address this bug when I have some more time, I think your PR is already trying to fix it. |
Owner
|
This has now been fixed in 0.0.76. Let me know if you still experience any issue. |
Contributor
Author
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Back with a change that would aid a little bit of local development support on macOS.
I understand that boomnet is not intended to be used with blocking sockets, and probably definitely not with macOS, and if you feel that this change is against the spirit of the crate, feel free to close.
This change adjusts the
complete_iofunction to remedy blocking sockets stalling during the read process.I thought maybe a feature would be more appropriate compared to use the
target_osflag.