Conversation
| ALPHABET_AUTOMATIC_SHIFTED(R.string.spoken_description_mode_alpha), | ||
| ALPHABET_MANUAL_SHIFTED(R.string.spoken_description_shiftmode_on), | ||
| ALPHABET_SHIFT_LOCKED(R.string.spoken_description_shiftmode_locked), | ||
| ALPHABET_SHIFT_LOCK_SHIFTED(R.string.spoken_description_shiftmode_locked), // todo: what? |
There was a problem hiding this comment.
What do you mean with the comment? That there is no separate string available?
| val res = mKeyboardView.resources | ||
| val modeText = res.getString(keyboard.mId.mode.contentDescription) | ||
| val text = res.getString(R.string.announce_keyboard_mode, modeText) | ||
| // TODO: this is saying "Showing showing (text) keyboard" |
There was a problem hiding this comment.
Did it always say "showing showing", or is this new?
How do I actually test this? Looks like I need "accessibility" enabled, but the accessibility settings on my phone don't have a generic on/off switch...
| break; | ||
| case KeyCode.SEND_INTENT_ONE, KeyCode.SEND_INTENT_TWO, KeyCode.SEND_INTENT_THREE: | ||
| IntentUtils.handleSendIntentKey(mLatinIME, event.getKeyCode()); | ||
| mLatinIME.requestHideSelf(0); |
There was a problem hiding this comment.
Why add this? Even if it makes sense, it should not be in a completely unrelated commit / PR.
There was a problem hiding this comment.
This catches me by surprise, I don't remember anything like this.
I need to look a lot closer at this patch and see if anything else fishy is going on. My best guess is it's a fragment from some incorrect merge/rebase handling on my part.
Apologies.
|
No issues with the enum changes, but I'm not happy with the style changes in here. I think we discussed a somewhat similar style thing already in a previous PR... My main issue is consistency (AOSP style might be pointless, but it's consistent). Now we mostly have the |
See #2249.
Sure. See Java 10 inspections for |
3 participants
I sat down to work on #2250 and realized I couldn't proceed before extracting the constant series from
KeyboardIdinto enums. So that's what I've done.I deleted the parallel XML enums since they're already out of date and don't seem to be used for anything? Let me know if this is a bad idea.
This one wound up being less commit-organized than the last one, apologies for that.