Sidebar Language Support#30
Open
Freyja-Folkvangr wants to merge 2 commits intoHerculesWS:masterfrom
Freyja-Folkvangr:sidebar-language-support
Open
Sidebar Language Support#30Freyja-Folkvangr wants to merge 2 commits intoHerculesWS:masterfrom Freyja-Folkvangr:sidebar-language-support
Freyja-Folkvangr wants to merge 2 commits intoHerculesWS:masterfrom
Freyja-Folkvangr:sidebar-language-support
Conversation
Note: It may break custom themes. See what to change in themes/<yours>/main/sidebar.php
|
@MishimaHaruna accept this 😁 |
Member
|
@HerculesWS/developers can anyone review this? I can't say I like the idea of using the translation identifiers as menu identifiers and forcing a call to Flux::message on all menu identifiers, but then again it's not much worse than the current implementation that uses the visual label as menu identifier. I can certainly 'accept' this (although I'm not the FluxCP fork's maintainer), but since it clearly states that the emphaino theme (which we ship) is not supported yet, I can't just merge it. |
Author
|
I'm out of time atm, I'll do some extra work when I get some time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A year ago I did this for rA's FluxCP, now I'm moving to Hercules~
Ref: rathena/FluxCP@8f95e74
Demo: http://www.freyja-ro.me
Note: It may break custom themes. See what to change in
themes/yours/main/sidebar.php
themes/yours/main/loginbox.php
*Not implemented in emphaino theme yet