[3차] 방금그곡 #30
+49
−0
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| func solution(_ m: String, _ musicinfos: [String]) -> String { | ||
|
|
||
| // 분 변환 | ||
| func toMinute(_ time: String) -> Int { | ||
| let t = time.split(separator: ":").map { Int($0)! } | ||
| return t[0] * 60 + t[1] | ||
| } | ||
|
|
||
| // 반음처리 | ||
| func halfStep(_ s: String) -> String { | ||
| return s | ||
| .replacingOccurrences(of: "C#", with: "c") | ||
| .replacingOccurrences(of: "D#", with: "d") | ||
| .replacingOccurrences(of: "F#", with: "f") | ||
| .replacingOccurrences(of: "G#", with: "g") | ||
| .replacingOccurrences(of: "A#", with: "a") | ||
| .replacingOccurrences(of: "B#", with: "C") | ||
| .replacingOccurrences(of: "E#", with: "F") | ||
| } | ||
|
Comment on lines
+10
to
+19
There was a problem hiding this comment.
func halfStep(_ s: String) -> String {
let replacements = [
"C#": "c", "D#": "d", "F#": "f", "G#": "g", "A#": "a", "B#": "C", "E#": "F"
]
return replacements.reduce(s) { $0.replacingOccurrences(of: $1.key, with: $1.value) }
} |
||
|
|
||
| let goal = halfStep(m) | ||
| var result = "(None)" | ||
| var maxTime = -1 | ||
|
|
||
| for info in musicinfos { | ||
| let parts = info.split(separator: ",").map { String($0) } | ||
| let start = toMinute(parts[0]) | ||
| let end = toMinute(parts[1]) | ||
| let playTime = end - start | ||
| let title = parts[2] | ||
| let melody = Array(halfStep(parts[3])) | ||
|
|
||
| if melody.isEmpty { continue } | ||
|
|
||
| var played = "" | ||
| for i in 0..<playTime { | ||
| played.append(melody[i % melody.count]) | ||
| } | ||
|
Comment on lines
+35
to
+38
There was a problem hiding this comment.
let melodyString = String(melody)
let repeatedCount = playTime / melody.count
let remainingCount = playTime % melody.count
let played = String(repeating: melodyString, count: repeatedCount) + melodyString.prefix(remainingCount) |
||
|
|
||
| if played.contains(goal) { | ||
| if playTime > maxTime { | ||
| maxTime = playTime | ||
| result = title | ||
| } | ||
| } | ||
| } | ||
|
|
||
| return result | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
toMinute함수에서Int($0)!를 사용하여 강제 언래핑을 하고 있습니다. 이는 입력값이 항상 "HH:MM" 형식의 유효한 정수임을 가정하지만, 만약 그렇지 않은 경우 런타임 오류를 발생시켜 앱을 중단시킬 수 있습니다.compactMap을 사용하여 옵셔널을 안전하게 해제하고,guard문으로 배열의 크기를 확인하여 코드를 더 견고하게 만드는 것이 좋습니다.