Skip to content

Add td_error_abs summary to TDLoss #1828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuantuMope merged 1 commit into from
Mar 16, 2026
Merged

Add td_error_abs summary to TDLoss #1828

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion alf/algorithms/td_loss.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
import alf
from alf.data_structures import LossInfo, namedtuple, StepType
from alf.utils.losses import element_wise_squared_loss, iqn_huber_loss
from alf.utils import losses, tensor_utils, value_ops
from alf.utils import tensor_utils, value_ops
from alf.utils.summary_utils import safe_mean_hist_summary
from alf.utils.normalizers import AdaptiveNormalizer

Expand Down Expand Up @@ -217,6 +217,8 @@ def _summarize(v, r, td, suffix):
safe_mean_hist_summary('values' + suffix, v, mask)
safe_mean_hist_summary('returns' + suffix, r, mask)
safe_mean_hist_summary("td_error" + suffix, td, mask)
safe_mean_hist_summary('td_error_abs' + suffix, td.abs(),
mask)

if value.ndim == 2:
_summarize(value, returns, td_error, '')
Expand Down
Loading