Add average_all_summaries context manager#1829
Open
QuantuMope wants to merge 2 commits intopytorchfrom
Open
Conversation
emailweixu
reviewed
Mar 16, 2026
alf/summary/summary_ops.py
Outdated
Comment on lines
+144
to
+145
| alf.summary.record_if = _disabled_record_if | ||
| alf.summary.should_record_summaries = lambda: True |
Contributor
There was a problem hiding this comment.
Why do these two need to be changed?
Contributor
Author
There was a problem hiding this comment.
record_if must be changed so that the recording interval set by the user is actually used.
should_record_summaries actually shouldn't be overridden as doing so is redundant. I've removed this check. Unit test still passes successfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A useful context manager for computing summary averages over an interval.
Nice to have because several alf algorithms have averaging off as default.
If using these summaries with a small mini-batch-size, we can selectively control which nested summaries get averaged without having to overwrite the source code.