Add feature to optionally set headers after servlet execution (setHeadersAfterServlet) and to optionally append values (appendValues)#5
Open
jamiejackson wants to merge 2 commits intoHory314:masterfrom
Conversation
Author
|
This works in unit tests but might not work in situ. I'm not too sure how to troubleshoot. Still investigating... |
jamiejackson
force-pushed
the
before_and_after
branch
from
dc1f6fe to
17c3490
Compare
Author
|
I learned that the servlet will auto-commit the response unless the auto-commit is wrapped to allow deferred commit. The wrapper allows for setting headers after the servlet is executed. |
jamiejackson
changed the title
setHeadersAfterServlet) and to optionally append values (appendValues)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch is built on top of another branch with an open PR.