SDK-492/Make LegacyUsbRegistry constructor public#8
Merged
smy-huddly merged 3 commits intov2-huddlyfrom Dec 6, 2024
Merged
Conversation
smy-huddly
force-pushed
the
smy_discovery_fix
branch
2 times, most recently
from
67c0156 to
1eff92e
Compare
smy-huddly
force-pushed
the
smy_discovery_fix
branch
from
511c845 to
7156f80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Part of fixing issue SDK-491 "LibUsbDotNet makes call to all USB devices during enumeration"
Steps to Reproduce
Debug USB discovery in SDK or start any client using the SDK
Expected Result
USB discovery should only make calls to the Huddly devices we care about, we should at least be able to filter on VID and PID
Actual Result
When enumerating devices LibUsbDotNet makes calls to all USB devices, this causes issues with some devices
Environment
Operating System: Windows / Any?
Device/Platform: All
Version: SDK 2.16.1, LibUsbDotNet 2.2.33