Open
Conversation
pkhansen
force-pushed
the
framing-subscriber
branch
from
5c28952 to
4e17ac1
Compare
Collaborator
Author
|
Tests failing while it's referencing a git depedency with npm. Will update and have tests passing before merge whenever the sdk-interfaces with approriate interfaces is released. |
eskilgh
approved these changes
Dec 8, 2022
| /** | ||
| * Class for handling framing subscriptions | ||
| */ | ||
| export default class MsgBusSubscriber implements IMsgBusSubscriber { |
Contributor
There was a problem hiding this comment.
If we want improved typing we could make this class generic, where the provided type is whatever message is passed to the subscriptionHandler
MsgBusSubscriber<Detections>
Collaborator
Author
There was a problem hiding this comment.
If I understand you correctly that means that we will have to reinstantiate the subscriber when switching framing modes? Not necessarily against that though. It also gave me an idea for the interface
Contributor
There was a problem hiding this comment.
Yes that's a good point. Or you could do a discriminated union type and check for whatever is present
pkhansen
force-pushed
the
framing-subscriber
branch
2 times, most recently
from
73907dd to
0992ea4
Compare
pkhansen
force-pushed
the
framing-subscriber
branch
from
0992ea4 to
7ea7120
Compare
pkhansen
force-pushed
the
framing-subscriber
branch
from
7ea7120 to
dd84d9b
Compare
pkhansen
force-pushed
the
framing-subscriber
branch
from
dd84d9b to
71582e5
Compare
The new subcriber is used in the detector class to refactor out detection and framing subscription handling. - Added functionality to update framing subscriber to use different framing subscription and handler functions.
pkhansen
force-pushed
the
framing-subscriber
branch
from
71582e5 to
c270708
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new subcriber is used in the detector class to refactor out detection and framing subscription handling.