Skip to content

Conversation

@ZloyNick
Copy link

@ZloyNick ZloyNick commented May 4, 2020

This commit adds 2 get|set methods:
Player::getSaturation();
Player::setSaturation($val);

and makes Enchanted Golden Apples are workable.

This commit adds 2 get|set methods:
    Player::getSaturation();
    Player::setSaturation($val);

and makes Enchanted Golden Apples are workable.
@yoraze
Copy link

yoraze commented May 4, 2020

#926 (comment)

@ImDaRealAni
Copy link

ImDaRealAni commented May 4, 2020

#926 (comment)
Hydreon never merges public PRs anymore.

@ZloyNick
Copy link
Author

ZloyNick commented May 5, 2020

You made a typo in line 2888

Fixed. Thanks.

@IceCruelStuff
Copy link

Maybe you should use public function getSaturation(): float and
public function setSaturation(float $sat)

@ZloyNick
Copy link
Author

Maybe you should use public function getSaturation(): float and
public function setSaturation(float $sat)

SteadFast2 haven't types declaration.

@dktapps
Copy link
Member

dktapps commented May 10, 2020

This PR is a waste of time as pointed out by myself in the comment linked above, which, you might notice, was given a 👍 by one of the Steadfast maintainers. So, it really makes no difference whether you apply those type hints or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants