Use pytest.ini_options.pythonpath instead of modifying sys.path in test modules#95
Merged
oskarhurst merged 2 commits intoHydrologicEngineeringCenter:mainfrom Jul 2, 2025
Conversation
Following conventions recommended on [pytest](https://docs.pytest.org/en/stable/explanation/goodpractices.html), setting the `pytest.ini_options.pythonpath` variable in the pyproject.toml file avoids needed to modify `sys.path` before each testing module begins.
Clean up the import statements for each testing module.
Contributor
|
Hi @dwr-zroy, Thank you for the PR this looks like a good addition to simplify the project. |
oskarhurst
approved these changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies
pyproject.tomland sets apytestsetting to automatically add.\srcto the PYTHONPATH. This alleviates the need to modifysys.pathwhen writing test modules.Tests are passing 100% on my Windows 11 machine, in a Python 3.12 environment. Not sure if there is a larger testing matrix that should be run.
Code Changes
Before
pyproject.tomltest_basics.pyAfter
pyproject.tomltest_basics.py