Skip to content

Remove submodule update step [ci patch inc]#11

Merged
HyperWinX merged 6 commits intomasterfrom
move-to-gh-runners
Apr 8, 2025
Merged

Remove submodule update step [ci patch inc]#11
HyperWinX merged 6 commits intomasterfrom
move-to-gh-runners

Conversation

@HyperWinX
Copy link
Member

No description provided.

@mentatbot
Copy link

mentatbot bot commented Apr 7, 2025

I'm getting to work. See my steps and track my cost here.

  • Wake on any new activity.
    I always see new activity while actively working. When paused, I'll only respond when tagged unless this box is checked.

@mentatbot
Copy link

mentatbot bot commented Apr 7, 2025

I've reviewed the changes in this PR and it looks good overall. The main changes are:

  1. Moving from self-hosted runners to GitHub-hosted runners (ubuntu-latest) with Docker containers
  2. Removing the redundant git submodule update step since the checkout action already handles this with submodules: 'true'

However, I noticed one inconsistency: in the version-increment.yml workflow, only the patch increment job has been updated to use GitHub-hosted runners, while the minor increment job still uses self-hosted runners:

# Line 28 in version-increment.yml
  versioning-minor-increment:
    runs-on: self-hosted  # <-- This should be updated to match the patch increment job

This should be updated to:

  versioning-minor-increment:
    runs-on: ubuntu-latest
    container: hyperwin/hcpu-ci:debian-unstable

to be consistent with the other changes in this PR.

@HyperWinX
Copy link
Member Author

@MentatBot

@mentatbot
Copy link

mentatbot bot commented Apr 7, 2025

Thanks for making the suggested change! The PR now looks great with consistent configuration across all workflows:

  1. All workflows use GitHub-hosted runners with Docker containers
  2. The redundant git submodule update steps have been removed since the checkout action handles this
  3. Both version increment jobs (patch and minor) now use the same runner configuration

The CI is currently running on the updated PR. Once it passes, this should be good to merge.

@HyperWinX
Copy link
Member Author

@MentatBot

@mentatbot
Copy link

mentatbot bot commented Apr 8, 2025

I see you've made additional improvements to the workflows:

  1. Removed the GTest Parallelizer and simplified test execution:

    • Now running tests directly with --gtest_brief flag instead of using the parallelizer
    • Removed the step to install GTest Parallelizer
  2. Removed the "Install all tools" step from the feature branch workflow

These changes are good improvements that further simplify the workflows. Since you're using Docker containers (hyperwin/hcpu-ci:debian-unstable), all the necessary tools should already be installed in the container, making these simplifications appropriate.

The changes look good and should make the CI process more robust by reducing external dependencies. The workflows are now more concise while still performing all the necessary checks.

@HyperWinX HyperWinX merged commit 2a58f44 into master Apr 8, 2025
12 checks passed
@HyperWinX HyperWinX deleted the move-to-gh-runners branch April 13, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments