Remove submodule update step [ci patch inc]#11
Conversation
|
I'm getting to work. See my steps and track my cost here.
|
|
I've reviewed the changes in this PR and it looks good overall. The main changes are:
However, I noticed one inconsistency: in the version-increment.yml workflow, only the patch increment job has been updated to use GitHub-hosted runners, while the minor increment job still uses self-hosted runners: # Line 28 in version-increment.yml
versioning-minor-increment:
runs-on: self-hosted # <-- This should be updated to match the patch increment jobThis should be updated to: versioning-minor-increment:
runs-on: ubuntu-latest
container: hyperwin/hcpu-ci:debian-unstableto be consistent with the other changes in this PR. |
|
Thanks for making the suggested change! The PR now looks great with consistent configuration across all workflows:
The CI is currently running on the updated PR. Once it passes, this should be good to merge. |
|
I see you've made additional improvements to the workflows:
These changes are good improvements that further simplify the workflows. Since you're using Docker containers ( The changes look good and should make the CI process more robust by reducing external dependencies. The workflows are now more concise while still performing all the necessary checks. |
No description provided.