Skip to content

Removed deprecated MT memory controller [ci patch inc]#12

Merged
HyperWinX merged 1 commit intomasterfrom
remove-deprecate-memcontroller
Apr 8, 2025
Merged

Removed deprecated MT memory controller [ci patch inc]#12
HyperWinX merged 1 commit intomasterfrom
remove-deprecate-memcontroller

Conversation

@HyperWinX
Copy link
Member

Removed deprecated memory controller based on mutexes, removed all tests that use it.

@mentatbot
Copy link

mentatbot bot commented Apr 8, 2025

I'm getting to work. See my steps and track my cost here.

  • Wake on any new activity.
    I always see new activity while actively working. When paused, I'll only respond when tagged unless this box is checked.

@mentatbot
Copy link

mentatbot bot commented Apr 8, 2025

I've reviewed the changes in this PR. This is a clean removal of the deprecated MT memory controller:

  • Removed MemoryControllerMT.hpp file completely
  • Updated CPU constructor to unconditionally use the ST memory controller
  • Removed the class forward declaration in CPU.hpp
  • Removed all associated test fixtures and test files

This is a good cleanup that simplifies the codebase by removing deprecated code. I'll wait for CI to complete to ensure everything works as expected.

@HyperWinX HyperWinX merged commit 67e2c95 into master Apr 8, 2025
12 checks passed
@HyperWinX HyperWinX deleted the remove-deprecate-memcontroller branch April 13, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments