Skip to content

Enable cron [ci patch inc]#16

Merged
HyperWinX merged 24 commits intomasterfrom
docker-image-autobuild
Apr 18, 2025
Merged

Enable cron [ci patch inc]#16
HyperWinX merged 24 commits intomasterfrom
docker-image-autobuild

Conversation

@HyperWinX
Copy link
Member

No description provided.

@mentatbot
Copy link

mentatbot bot commented Apr 18, 2025

I'm getting to work. See my steps and track my cost here.

  • Wake on any new activity.
    I always see new activity while actively working. When paused, I'll only respond when tagged unless this box is checked.


steps:
- name: Install Docker Buildx
uses: docker/setup-buildx-action@v3

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'HyperCPU CI/CD Pipeline (update Docker images)' step
Uses Step
uses 'docker/setup-buildx-action' with ref 'v3', not a pinned commit hash
uses: docker/setup-buildx-action@v3

- name: Login to DockerHub
uses: docker/login-action@v3

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'HyperCPU CI/CD Pipeline (update Docker images)' step
Uses Step
uses 'docker/login-action' with ref 'v3', not a pinned commit hash
submodules: true

- name: Build and push
uses: docker/build-push-action@v6

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'HyperCPU CI/CD Pipeline (update Docker images)' step
Uses Step
uses 'docker/build-push-action' with ref 'v6', not a pinned commit hash
name: "Update Gentoo Musl Docker image - stage 1"
steps:
- name: Login to DockerHub
uses: docker/login-action@v3

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'HyperCPU CI/CD Pipeline (update Docker images)' step
Uses Step
uses 'docker/login-action' with ref 'v3', not a pinned commit hash
submodules: true

- name: Build and push
uses: docker/build-push-action@v6

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'HyperCPU CI/CD Pipeline (update Docker images)' step
Uses Step
uses 'docker/build-push-action' with ref 'v6', not a pinned commit hash
needs: build-gentoo-musl-stage1
steps:
- name: Login to DockerHub
uses: docker/login-action@v3

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'HyperCPU CI/CD Pipeline (update Docker images)' step
Uses Step
uses 'docker/login-action' with ref 'v3', not a pinned commit hash
submodules: true

- name: Build and push
uses: docker/build-push-action@v6

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'HyperCPU CI/CD Pipeline (update Docker images)' step
Uses Step
uses 'docker/build-push-action' with ref 'v6', not a pinned commit hash
Copy link

@mentatbot mentatbot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed the PR adding Docker support to HyperCPU and found several issues that should be addressed:

Major Issues

  1. Cron Schedule Issue

    schedule:
      - cron: "* * */7 * *"

    This cron pattern will run every minute of every hour on every 7th day of the month. You probably want something like "0 0 */7 * *" (midnight every 7th day) instead.

  2. Dockerfile Best Practices

    • Multiple RUN commands should be combined with && to reduce image layers
    • Example in Alpine Dockerfile:
      # Instead of:
      RUN apk update
      RUN apk add clang gcc git cmake make gtest-dev gtest-src re2 re2-dev fmt fmt-dev nodejs grep
      
      # Better as:
      RUN apk update && \
          apk add clang gcc git cmake make gtest-dev gtest-src re2 re2-dev fmt fmt-dev nodejs grep
  3. Unknown Command in Gentoo Dockerfiles

    RUN getuto

    This command appears in both Gentoo Dockerfiles and doesn't seem to be a standard Gentoo command. Is this a typo?

  4. Shell Command Issues

    RUN source /etc/profile

    This won't persist across container builds. Each RUN instruction is executed in a separate shell.

Minor Issues

  1. Unnecessary File

    • docker/gentoo-glibc/Dockerfile.save should be removed from the repository
  2. Security Alerts

    • GitHub security scanning has flagged unpinned action versions
    • Consider using specific commit hashes instead of version tags for GitHub Actions like:
      # Instead of:
      uses: docker/build-push-action@v6
      
      # Use specific commit hash:
      uses: docker/build-push-action@4a13e500e55cf31b7a5d59a38ab2040ab0f42f56
  3. Image Optimization

    • Consider using specific version tags for base images where stable environments are needed
    • Adding image labels for metadata (maintainer, version, etc.)

Would you like me to suggest specific fixes for any of these issues?

@HyperWinX HyperWinX merged commit 90a5099 into master Apr 18, 2025
11 checks passed
HyperWinX added a commit that referenced this pull request Apr 21, 2025
* Add dockerfiles

* Add workflow

* Fix workflow

* Fix workflow

* Fix workflow

* Fix workflow

* Fix workflow

* Fix workflow

* Update dockerfiles

* Update workflow

* Split Gentoo into three stages

* Add NodeJS everywhere

* Fix tag names

* Update workflows

* Enable cron

* Update docker-autobuild.yml

* Update Dockerfile

* Update Dockerfile

* Update Dockerfile

* Update Dockerfile

* Update Dockerfile

* Update Dockerfile

* Update Dockerfile

* Update Dockerfile
@HyperWinX HyperWinX deleted the docker-image-autobuild branch May 12, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments