Skip to content

Move to GitFlow strategy [ci patch inc]#7

Closed
HyperWinX wants to merge 1 commit intomasterfrom
move-to-gitflow
Closed

Move to GitFlow strategy [ci patch inc]#7
HyperWinX wants to merge 1 commit intomasterfrom
move-to-gitflow

Conversation

@HyperWinX
Copy link
Member

Update workflows to comply with GitFlow strategy rules.

@mentatbot
Copy link

mentatbot bot commented Apr 4, 2025

I'm getting to work. See my steps and track my cost here.

  • Wake on any new activity.
    I always see new activity while actively working. When paused, I'll only respond when tagged unless this box is checked.

@mentatbot
Copy link

mentatbot bot commented Apr 4, 2025

I've reviewed your GitFlow implementation PR and it looks good! Here's what I like about the changes:

  1. Clear separation of workflows:

    • Feature branch testing happens automatically on push
    • PR testing and versioning happens on PRs to master
  2. Explicit versioning:

    • Using [ci patch inc] and [ci minor inc] tags makes versioning intentional
    • Removed automatic versioning that could be triggered unintentionally
  3. Simplified workflow:

    • Removed complex branch manipulation and force pushes
    • Cleaner commit messages for version increments

One question: I noticed the versioning-patch-increment job no longer depends on the testing job. Is this intentional? This would allow patch version increments without tests passing first. If you're relying on PR checks to ensure tests pass before merging, that might be acceptable, but wanted to check.

Overall, this looks like a good move toward a more maintainable GitFlow workflow!

@HyperWinX HyperWinX closed this Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant