Skip to content

Move to GitFlow strategy [ci patch inc]#8

Merged
HyperWinX merged 3 commits intomasterfrom
move-to-gitflow
Apr 4, 2025
Merged

Move to GitFlow strategy [ci patch inc]#8
HyperWinX merged 3 commits intomasterfrom
move-to-gitflow

Conversation

@HyperWinX
Copy link
Member

Update workflows to comply with GitFlow strategy rules.

@mentatbot
Copy link

mentatbot bot commented Apr 4, 2025

I'm getting to work. See my steps and track my cost here.

  • Wake on any new activity.
    I always see new activity while actively working. When paused, I'll only respond when tagged unless this box is checked.

@mentatbot
Copy link

mentatbot bot commented Apr 4, 2025

Hi there! I've reviewed your PR for migrating to GitFlow and found a few issues that should be addressed:

1. Duplicate versioning jobs

The same versioning jobs appear in both testing.yml and version-increment.yml. This could lead to duplicate version increments if both workflows run for the same change.

2. Inconsistent dependencies

  • In testing.yml, the versioning-minor-increment job depends on testing (needs: [testing]), but versioning-patch-increment doesn't have this dependency
  • In version-increment.yml, neither versioning job depends on testing

This means versions could be incremented without tests passing in some cases.

3. Incorrect commit messages

Both versioning-minor-increment jobs use the commit message "Increment patch version" even though they're incrementing the minor version.

Recommendations:

  1. Separate concerns clearly:

    • testing.yml should only handle testing on PRs
    • version-increment.yml should handle version increments on merged PRs
  2. Fix dependency structure:

    • All version increment jobs should depend on tests passing
    • Consider adding needs: [testing] to the patch increment job in testing.yml
  3. Fix commit messages:

    • Change the commit message in minor increment jobs to say "Increment minor version"
  4. Clarify workflow purpose:

    • Consider adding comments explaining when each workflow runs in GitFlow
    • Document which branch tests run on and when versions get incremented

Would you like me to help with implementing these changes?

fetch-depth: '0'

- name: Setup git user
uses: fregante/setup-git-user@v1

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'HyperCPU CI/CD Pipeline (version incrementing)' step
Uses Step
uses 'fregante/setup-git-user' with ref 'v1', not a pinned commit hash
fetch-depth: '0'

- name: Setup git user
uses: fregante/setup-git-user@v1

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'HyperCPU CI/CD Pipeline (version incrementing)' step
Uses Step
uses 'fregante/setup-git-user' with ref 'v1', not a pinned commit hash
@HyperWinX HyperWinX merged commit 1850fd1 into master Apr 4, 2025
3 of 4 checks passed
@HyperWinX HyperWinX deleted the move-to-gitflow branch April 6, 2025 18:49
HyperWinX added a commit that referenced this pull request Apr 12, 2025
* Move to GitFlow strategy

* Update testing.yml

* Update version-increment.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant